added a failure field to the future that fails if it happens - #28
added a failure field to the future that fails if it happens#28Saaketh0 wants to merge 5 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| self._process_request(data) | ||
| except json.JSONDecodeError: | ||
| logger.error("Invalid JSON in request: %s", raw) | ||
| except Exception as e: |
There was a problem hiding this comment.
Shouldn't we merge these two excepts across the two lines rather than having two except and mark both failed
| "request_id": self.request_id or "", | ||
| "result": "", | ||
| "parent": self.parent, | ||
| "service": self.service, |
There was a problem hiding this comment.
I think maybe add the failure and error fields here
2 participants
No description provided.