Add touch input#19
Merged
Merged
Conversation
A touch-to-mouse bridge (_attachTouch, attached per panel in _attachPanelEvents) translates touch gestures into the existing mouse/wheel handlers via real MouseEvent/WheelEvent dispatch, so every panel kind and every example becomes touch-capable with no handler rewrites: - 1 finger drag -> pan / orbit / drag a widget, ROI, marker or plane - 2 fingers pinch -> zoom (wheel), centred on the gesture midpoint - double-tap -> dblclick -> the panel's double_click event move/up dispatch to document (handlers listen there for off-canvas drags); down/wheel/dblclick to the overlay canvas. Overlay canvases set touch-action:none so the browser yields gestures to the plot rather than scrolling the page. Tests: Playwright touch emulation (has_touch=True) across 2D/3D/1D drag, pinch zoom, and double-tap; 416 existing mouse-interaction tests unchanged. Full suite 1330 passed / 58 skipped.
CSSFrancis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 90.62% 90.62%
=======================================
Files 33 33
Lines 2741 2741
=======================================
Hits 2484 2484
Misses 257 257 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A touch-to-mouse bridge (_attachTouch, attached per panel in _attachPanelEvents) translates touch gestures into the existing mouse/wheel handlers via real MouseEvent/WheelEvent dispatch, so every panel kind and every example becomes touch-capable with no handler rewrites:
move/up dispatch to document (handlers listen there for off-canvas drags); down/wheel/dblclick to the overlay canvas. Overlay canvases set touch-action:none so the browser yields gestures to the plot rather than scrolling the page.
Tests: Playwright touch emulation (has_touch=True) across 2D/3D/1D drag, pinch zoom, and double-tap; 416 existing mouse-interaction tests unchanged.