Skip to content

feat: polished loop create/edit form (closes #21)#30

Merged
CKGrafico merged 3 commits into
mainfrom
feature/gh-21-polished-loop-form
Jul 3, 2026
Merged

feat: polished loop create/edit form (closes #21)#30
CKGrafico merged 3 commits into
mainfrom
feature/gh-21-polished-loop-form

Conversation

@CKGrafico

Copy link
Copy Markdown
Owner

Closes #21.

Summary

Implement the polished loop create/edit form with task selection, inline command editing, smart defaults, copy-on-edit, direct edit navigation, and real-time per-field validation across board and TUI.

Changes

  • Shared validation hook (src/hooks/useLoopFormValidation.ts): single \�alidateField/\�alidateAll\ delegating to \parseDuration(), \parseMaxRuns(), \�uildLoopOptions()\ — both board and TUI consume it
  • **Board \CreateForm.tsx**: two-column grid, per-field inline errors, field-level validation on change + submit, task mode toggle (inline/existing) with field reset, copy-to-clipboard for command/cwd, smart CWD default (\process.cwd()), direct edit navigation (bypasses DetailView)
  • **TUI \WizardForm.tsx**: per-step validation via shared hook, errors on blur/move/submit, task mode toggle with field clearing, Ctrl+Y copy-to-clipboard
  • **TUI \CreateForm.tsx**: command args merged/re-parsed via \parseCommandLine(), CWD pre-filled
  • **Removed \DetailView.tsx**: edit action now routes directly to CreateForm in edit mode
  • Docs: added guard warning in AGENTS.md + README.md that ttyd is opt-in only (agents must not use it unless explicitly asked)

Verification

  • \ sc --noEmit\ passes with zero errors
  • \pnpm lint\ shows 87 pre-existing errors (identical to main baseline — zero new)
  • \pnpm test\ shows only pre-existing failures (loop-config 2, client-commands 2, daemon-server 29 EACCES permission, loop-controller 2 — all match main)

Issue Reference

Closes #21

CKGrafico and others added 3 commits July 3, 2026 12:41
The change had proposal + design + specs but no tasks.md, so it could
not pass through /ob-apply or be archived. Verified each of the six
proposed capabilities against the actual codebase (shared validation
hook, task mode toggle, inline command copy, smart cwd default, direct
edit navigation, per-field validation) - all six were already implemented
across prior WIP commits (d29f6a9, 1e16395). Retroactive tasks.md marks
them [x] against verified code rather than re-describing planned work.

One genuine gap found and fixed: src/board/components/DetailView.tsx was
dead code (zero imports repo-wide) left over from before direct-edit-
navigation bypassed it. Removed. Typecheck clean, full suite at the known
baseline (37 failed / 500 passed, unchanged).

openspec status now shows all 4 artifacts complete - ready to archive.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@CKGrafico
CKGrafico merged commit 56c10bb into main Jul 3, 2026
0 of 3 checks passed
@CKGrafico
CKGrafico deleted the feature/gh-21-polished-loop-form branch July 3, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant