Add visible border to asset selection checkboxes#2214
Conversation
This comment has been minimized.
This comment has been minimized.
Visual recap — skipped (diff too small)The change in this pull request is too small to be worth a visual recap. This is informational only and does not block the PR. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Code Review Summary
PR #2214 makes a narrowly scoped styling adjustment in templates/assets/app/routes/brand-kits.$id.tsx, changing the two asset-selection checkboxes used by the Cards and Lanes views from an effectively invisible background-colored border to a thicker border-2 border-foreground/40. The approach is sound: it improves contrast without changing selection state, event handling, responsive visibility, hover behavior, or focus-visible behavior.
This is a low-risk UI-only change. Both independent review passes found no actionable bugs, security issues, performance regressions, or accessibility regressions. The class composition is compatible with the existing Checkbox implementation, and the unchanged toolbar/detail-panel checkboxes remain outside the patch. The browser-test planner designed a full 15-case verification pass, but execution was blocked because its executor sandboxes had no working browser automation tools; therefore no live visual evidence was collected.
✅ Good patterns: minimal diff, correct targeting of both affected views, and preservation of existing interaction classes.
🧪 Browser testing: Attempted but blocked — browser automation tools were unavailable in executor sandboxes; retry when the tooling is restored.
Summary
Updates the styling of asset selection checkboxes so they have a clearly visible border against the background.
Problem
The selection checkboxes on brand kit asset cards and lane tiles used a border color matching the background, making them hard to notice at a glance.
Solution
Changed the checkbox border styling to use a thicker, higher-contrast border so it stands out immediately regardless of the underlying image or background.
Key Changes
AssetCardsView, updated checkboxclassNamefromborder-backgroundtoborder-2 border-foreground/40.AssetLaneTile, updated checkboxclassNamefromborder-backgroundtoborder-2 border-foreground/40, keeping existing opacity/hover/focus-visible behavior intact.To clone this PR locally use the Github CLI with command
gh pr checkout 2214You can tag me at @BuilderIO for anything you want me to fix or change