Add durable authenticated preview handoff#2164
Conversation
This comment has been minimized.
This comment has been minimized.
Visual recap — not generatedThe recap was suppressed because the diff matched a secret/credential pattern. No plan was published. Reason: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Builder reviewed your changes and has a few items to flag 🟡
Review Details
Incremental Code Review Summary
Reviewed the latest PR update, including the OAuth doorway registration handoff and its new concurrency tests. The change correctly reserves a registration before listener startup, shares the in-flight listener promise, and prevents an older unregister callback from removing a newer registration. The focused doorway suite now covers concurrent startup and unregister-during-registration behavior, and the implementation is sound for this delta.
No new reportable issues were identified in the latest commit. Previously reported issues remain unchanged and were not reposted. The prior doorway-registration cleanup comment was verified fixed and resolved before this review.
Risk remains high overall because the PR changes authenticated preview sessions, OAuth routing, and protected proxy behavior.
🧪 Browser testing: Attempted after review, but all test cases were blocked by unavailable browser automation tools; Electron-only flows could not be attached in this environment.
What changed
agentnative://open?app=<id>&preview=<exact-origin>handoff for durable hosted review candidatessafeStorage, bound to one exact HTTPS originWhy
Agent Native candidate previews need stable hosted links that can be reviewed days later without keeping an app dev server alive or registering every Vercel preview as a Google OAuth callback. Framework Desktop becomes the trusted authenticated review surface while the hosted candidate remains durable and exact-revision addressable.
Security boundary
Verification
main:pnpm build,pnpm verify:pack,pnpm typecheck,pnpm lint,pnpm knip, and non-PTYpnpm testlocalhost:8083/dev, and shutdown left ports 3334/8080/8083 freeKnown unrelated behavior
Frame's existing AgentPanel Router error and an inactive Clips
localhost:8094connection warning remain visible in development logs. Neither blocks candidate review and neither is changed here.