Add support for DNSCacheManager - #158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for using JMeter's DNS Cache Manager in the HTTP plugin, ensuring that custom DNS resolution (such as static host entries and custom DNS servers) applies to HTTP requests just as it does for the HTTPHC4 sampler. The changes also ensure that DNS resolution is properly isolated per sampler and per thread, preventing cross-contamination between samplers with different DNS configurations. Comprehensive tests are included to verify correct integration and behavior.
DNS resolution integration and isolation:
JMeterDnsSocketAddressResolverclass that adapts JMeter'sDNSCacheManager(viaDnsResolver) for use by Jetty'sHttpClient, ensuring all protocol variants (HTTP/1.1, HTTP/2, HTTP/3) resolve hosts through the DNS Cache Manager when configured.HTTP2JettyClientto accept aDnsResolverin its constructor, store it, and install the custom resolver on each protocol client during configuration. [1] [2] [3] [4]HTTP2Samplerto pass the correct DNS resolver toHTTP2JettyClientand to ensure the client cache key includes the DNS Cache Manager instance, preventing clients from being shared across samplers with different DNS configurations. [1] [2] [3]Testing and verification:
HTTP2JettyClientDnsCacheManagerTestto verify that the DNS Cache Manager is correctly installed, that static host entries are respected, that proxy resolution targets the proxy host, and that client cache keys are isolated by DNS manager instance.