fix(argon2): add types condition to package.json exports map#9265
Open
rashadjnizar wants to merge 1 commit into
Open
fix(argon2): add types condition to package.json exports map#9265rashadjnizar wants to merge 1 commit into
rashadjnizar wants to merge 1 commit into
Conversation
rashadjnizar
force-pushed
the
fix/argon2-package-json-types-export
branch
from
c1079b9 to
87f6e2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@bitgo/argon2'sexports["."]map has notypescondition, so consumers on TypeScript's"moduleResolution": "bundler"can't resolveindex.d.tseven though it's referenced by thetypesfield.@bitgo/argon2directly from a Bun/TypeScript project (bunx tsc --noEmitfailed withTS7016: Could not find a declaration file for module '@bitgo/argon2'), and worked around it locally with abun patchcarrying this exact one-line diff, opening this so the real fix lands upstream instead.