crosswalk-parsing fixed PR

[aaravshar]

crosswalk parsing changes to xodr_parser and 1 scenario for pedestrian-vehicle interactions

[dfremont]

This should be a tuple.

Also, I think it's theoretically possible that you could have a crosswalk that connects to one of the two sidewalks but not the other, or a crosswalk connecting to no sidewalks. So it would be safer here to check that at least one of the endpoints of the crosswalk is close to the sidewalk (within the tolerance) before adding it.

[dfremont]

Looks good overall, thanks Aarav! I've pointed out a bunch of mostly-minor things above. The only other issue I can see is that there are no tests, but if necessary we could leave adding those to the next PR.

[codecov]

Codecov Report

❌ Patch coverage is 83.48214% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (454c8e1) to head (582e5af).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/scenic/formats/opendrive/xodr_parser.py	85.98%	30 Missing ⚠️
src/scenic/domains/driving/roads.py	30.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   89.87%   89.69%   -0.19%     
==========================================
  Files          48       48              
  Lines       13346    13568     +222     
==========================================
+ Hits        11995    12170     +175     
- Misses       1351     1398      +47     

Files with missing lines	Coverage Δ
src/scenic/domains/driving/roads.py	93.63% <30.00%> (-0.92%)	⬇️
src/scenic/formats/opendrive/xodr_parser.py	91.92% <85.98%> (-0.79%)	⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.