Fix E2E CI: pin mineflayer via committed lockfile (1.21.11 support)#423
Merged
Conversation
The on-demand E2E run failed in CI with "Server version '1.21.11' is not supported. Latest supported version is '1.21.4'." — without a committed package-lock.json, CI's fresh npm install resolved an older mineflayer/minecraft-data than the local run, and it didn't know 1.21.11. Commit the lockfile (mineflayer 4.37.1 / minecraft-data 3.111.0, which support 1.21.11) so installs are reproducible, and key the npm cache on the lockfile (also invalidates the stale node_modules the failed run cached under the package.json hash). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NKxodNE4h3TsSHMqDEeC8v
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The on-demand E2E workflow (added in #422) failed in CI — the tests never ran because the Mineflayer bot rejected the server version:
Cause
I'd gitignored
package-lock.json, so npm resolves dependency versions fresh on each install. Locally that gave mineflayer 4.37.1 / minecraft-data 3.111.0 (which support 1.21.11 — the tests passed), but CI's unlocked install resolved older versions that cap at 1.21.4. Classic non-reproducible-install bug.Fix
package-lock.json(pins mineflayer 4.37.1 / minecraft-data 3.111.0) so CI installs the same, 1.21.11-capable versions.package.json— more precise, and it invalidates the stalenode_modulesthe failed run cached.Verified against this branch via a
workflow_dispatchrun before merge.🤖 Generated with Claude Code