Increment versions for network releases#49719
Open
weidongxu-microsoft wants to merge 3 commits into
Open
Conversation
Aligns the Accept header on Microsoft.Network resource DELETE requests in two VirtualMachineOperationsTests recordings with the regenerated network library (application/json;q=0.9), fixing test-proxy playback mismatch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
weidongxu-microsoft
requested review from
a team,
ArthurMa1978,
XiaofeiCao and
haolingdong-msft
as code owners
github-actions
Bot
added
the
Mgmt
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-creates the automation version-increment changes for the azure-resourcemanager-network release train (superseding #49717) and includes a compute test-proxy assets tag update to fix playback mismatches caused by a changed Accept header on Network DELETE LRO requests.
Changes:
- Bumped
azure-resourcemanager-networkpackage version to2.60.0-beta.1and added a new unreleased changelog section. - Updated several modules’
azure-resourcemanager-networkdependency version from2.58.2to the released2.59.0. - Updated
azure-resourcemanager-computetest-proxy assets tag tojava/compute/azure-resourcemanager-compute_3eb6509c14(tag verified to exist inAzure/azure-sdk-assets).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storagemover/azure-resourcemanager-storagemover/pom.xml | Updates test dependency on azure-resourcemanager-network to 2.59.0. |
| sdk/resourcemanager/azure-resourcemanager/pom.xml | Updates azure-resourcemanager-network dependency to 2.59.0. |
| sdk/privatedns/azure-resourcemanager-privatedns/pom.xml | Updates test dependency on azure-resourcemanager-network to 2.59.0. |
| sdk/network/azure-resourcemanager-network/pom.xml | Increments package version to 2.60.0-beta.1. |
| sdk/network/azure-resourcemanager-network/CHANGELOG.md | Adds the 2.60.0-beta.1 (Unreleased) section. |
| sdk/hdinsight/azure-resourcemanager-hdinsight/pom.xml | Updates test dependency on azure-resourcemanager-network to 2.59.0. |
| sdk/cosmos/azure-resourcemanager-cosmos/pom.xml | Updates test dependency on azure-resourcemanager-network to 2.59.0. |
| sdk/containerinstance/azure-resourcemanager-containerinstance/pom.xml | Updates azure-resourcemanager-network dependency to 2.59.0. |
| sdk/computefleet/azure-resourcemanager-computefleet/pom.xml | Updates test dependency on azure-resourcemanager-network to 2.59.0. |
| sdk/compute/azure-resourcemanager-compute/pom.xml | Updates azure-resourcemanager-network dependency to 2.59.0. |
| sdk/compute/azure-resourcemanager-compute/assets.json | Updates assets tag to the new recordings snapshot used for playback. |
| eng/versioning/version_client.txt | Advances azure-resourcemanager-network from 2.59.0 to 2.60.0-beta.1. |
…work lib update Migrate 3 tests from retired unmanaged disks to managed disks, disable the multiple-role-assignment MSI test (requires Owner), and update recordings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Added commit 3a72315 re-enabling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #49717.
This re-creates the automation PR ""Increment versions for network releases"" (#49717) from an upstream branch, plus a fix for the failing compute test recordings.
Why
#49717 had failing
Build Testchecks. TwoVirtualMachineOperationsTestsrecordings (canBeginCreateAndDeleteWithContext,canCreateVirtualMachineWithDeleteOption) did not match playback because the regenerated network library now sendsAccept: application/json;q=0.9onMicrosoft.Networkresource DELETE (LRO) operations, while the recordings still hadapplication/json.The original PR could not be updated directly because its head branch is on the
azure-sdkbot fork (maintainers cannot push to it).Changes
sdk/compute/azure-resourcemanager-compute/assets.jsonto the new recordings tagjava/compute/azure-resourcemanager-compute_3eb6509c14(network DELETEAcceptheader aligned toapplication/json;q=0.9).Verified locally: both tests pass in playback (
Tests run: 2, Failures: 0, Errors: 0).Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com