Fixing subscription values - #34
Merged
Guy Pritchard MSFT (lovelysandwich) merged 6 commits intoMar 30, 2023
Merged
Conversation
…ned by a distinct list.
Guy Pritchard MSFT (lovelysandwich)
marked this pull request as ready for review
March 30, 2023 15:22
…into fixing_subscription_values
Guy Pritchard MSFT (lovelysandwich)
added
bug
Guy Pritchard MSFT (lovelysandwich)
requested a review
from Gabriel Monteiro Nepomuceno (Nepomuceno)
March 30, 2023 15:57
Gabriel Monteiro Nepomuceno (Nepomuceno)
approved these changes
Mar 30, 2023
Gabriel Monteiro Nepomuceno (Nepomuceno)
left a comment
Gabriel Monteiro Nepomuceno (Nepomuceno)
left a comment
Member
There was a problem hiding this comment.
Guy Pritchard MSFT (lovelysandwich)
deleted the
fixing_subscription_values
branch
March 30, 2023 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes Azure/Azure-Landing-Zones#2552
Fixes Azure/Azure-Landing-Zones#2553
Description
Changes to ensure that subscription ids persist as an array when only one value remains.
Handling case insensitive deduplication of subscription ids.
Fixes a part of the ReadMe.md (probably more work required, but fixing a small part of that document)
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.