feat: enhance the ToTo linter - #4100
Merged
Merged
Conversation
Previously it always flagged "to to" and only suggested "to do". It did not cooperate with `RepeatedWords` to suggest dropping the second "to", since that's not possible. It was not aware of patterns where "to to" is grammatically correct, such as after certain verbs and before a verb in the infinitive.
hippietrail
enabled auto-merge
August 18, 2026 09:58
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
Previously it always flagged "to to" and only suggested "to do".
It did not cooperate with
RepeatedWordsto suggest dropping the second "to", since that's not possible.It was not aware of patterns where "to to" is grammatically correct, such as after certain verbs and before a verb in the infinitive.
This PR moved the old linter out of
phrase_set_correctionsinto a custom Rust linter.I also added a new
surrounded_by_words()method toExprLinterthat combines the existingfollowed_by_token()andpreceded_by_word().How Has This Been Tested?
cargo testAI Disclosure
I asked Google's AI to suggest how best to implement
surrounded_by_words()and to write the doc comments.If Your PR Implements or Enhances a Linter
Checklist