Skip to content

Implement action timeout enforcement in sequential actions and set default timeout in MainDriverApi#704

Merged
sazid merged 3 commits into
devfrom
action_timeout
Jun 22, 2026
Merged

Implement action timeout enforcement in sequential actions and set default timeout in MainDriverApi#704
sazid merged 3 commits into
devfrom
action_timeout

Conversation

@mdshakib007

Copy link
Copy Markdown
Collaborator

Implement action timeout enforcement in sequential actions and set default timeout in MainDriverApi

2026-06-18_20-14-42 2026-06-18_20-14-31

@mdshakib007 mdshakib007 self-assigned this Jun 18, 2026
@riz-hossain

Copy link
Copy Markdown
Contributor

🔎 ZeuZ PR Review

Open the full report in ZeuZ: Review findings and apply suggestions

Overview Value
Agents ✅ 4 completed
Suggestions 💡 4

Agent breakdown

→ General Review

Status: ✅ Completed
Suggestions: 1 suggestion

I found one high-signal correctness issue in the timeout worker implementation: timed-out runs can leave stale results queued and corrupt the next action’s outcome.

→ Security Review

Status: ✅ Completed
Suggestions: 0 suggestions

No security-critical issues were introduced in the diff. The changes add action timeouts without exposing secrets, weakening auth, or adding injection paths.

→ Performance Review

Status: ✅ Completed
Suggestions: 1 suggestion

I found one scalability/resource-risk issue: timed-out actions leave behind abandoned daemon worker threads, so repeated timeouts can accumulate stuck threads and memory over a long test run.

→ Testing Review

Status: ✅ Completed
Suggestions: 2 suggestions

The PR adds important timeout behavior, but I don’t see regression coverage for either the new action-timeout path or the default shared-variable initialization.

Open ZeuZ to inspect full findings, continue an agent conversation, or apply safe patch suggestions.

@riz-hossain

Copy link
Copy Markdown
Contributor

🔎 ZeuZ PR Review

Open the full report in ZeuZ: Review findings and apply suggestions

Overview Value
Agents ✅ 4 completed
Suggestions 💡 4

Agent breakdown

→ General Review

Status: ✅ Completed
Suggestions: 1 suggestion

The timeout worker adds a useful safeguard, but it currently only guards the action function itself and can still leave other step phases running unbounded.

→ Security Review

Status: ✅ Completed
Suggestions: 0 suggestions

No security issues found in the PR diff. The changes add action timeout enforcement and a default runtime timeout without exposing new injection, auth, or secret-handling risks.

→ Performance Review

Status: ✅ Completed
Suggestions: 1 suggestion

No high-signal performance regressions found beyond a minor sleep-loop inefficiency that is unlikely to matter in typical runs.

→ Testing Review

Status: ✅ Completed
Suggestions: 2 suggestions

The timeout feature is substantial, but I don’t see any tests covering the new behavior or its default wiring, so the PR is currently under-tested for a high-risk path.

Open ZeuZ to inspect full findings, continue an agent conversation, or apply safe patch suggestions.

@riz-hossain

Copy link
Copy Markdown
Contributor

🔎 ZeuZ PR Review

Open the full report in ZeuZ: Review findings and apply suggestions

Overview Value
Agents ✅ 4 completed
Suggestions 💡 4

Agent breakdown

→ General Review

Status: ✅ Completed
Suggestions: 1 suggestion

I found one correctness issue: the new timeout wrapper only covers run_function(data_set), so any long pre_sleep/post_sleep delays still bypass the configured action_timeout and can keep a step running past the limit.

→ Security Review

Status: ✅ Completed
Suggestions: 1 suggestion

The PR adds per-action timeout enforcement, but the implementation can leave timed-out worker threads running indefinitely, creating a resource-exhaustion risk if an action hangs repeatedly.

→ Performance Review

Status: ✅ Completed
Suggestions: 1 suggestion

Found one resource-usage risk in the new timeout wrapper: timed-out actions abandon a worker thread, which can accumulate over repeated timeouts.

→ Testing Review

Status: ✅ Completed
Suggestions: 1 suggestion

The PR adds important timeout enforcement and a new default shared variable, but I don’t see any tests covering the new behavior or its regression risks.

Open ZeuZ to inspect full findings, continue an agent conversation, or apply safe patch suggestions.

@sazid sazid merged commit 46be58a into dev Jun 22, 2026
7 checks passed
@sazid sazid deleted the action_timeout branch June 22, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants