Decouple Moldflow API public PyPI publish from GitHub Release - #85
Merged
Conversation
Split publish.yml into github-release.yml and pypi-publish.yml. Add PyPI ordering guard that blocks publishing newer versions before older ones are on PyPI. Update RELEASE.md to document two-step release process.
sankalps0549
changed the title
sankalps0549
marked this pull request as ready for review
August 13, 2026 21:43
linan-1990
approved these changes
Aug 14, 2026
osinjoku
approved these changes
Aug 14, 2026
osinjoku
left a comment
osinjoku
left a comment
Contributor
There was a problem hiding this comment.
Decoupling looks correct: github-release.yml builds and archives the wheel on a GitHub Release first, and pypi-publish.yml downloads those assets and uploads to PyPI without rebuilding. This supports the monorepo consuming the GitHub Release before PyPI goes live. Tag vs version.json drift on long-lived release branches is expected and not a functional concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decouples the public PyPI publish from GitHub Release creation so that the Moldflow monorepo can consume the wheel (from GitHub Releases) before PyPI goes live. This avoids customers on 2027 FCS seeing
pip upgradeprompts for API versions their installed client doesn't support yet.Changes:
publish.ymlinto two workflows:github-release.yml(creates GH Release with wheel) andpypi-publish.yml(downloads wheel from GH Release, uploads to PyPI)github-release.ymlincludes a duplicate-release guard (fails if tag already exists)pypi-publish.ymlincludes a PyPI ordering guard (blocks publishing a newer version when older GitHub Releases haven't been published to PyPI yet)check-publish-alignment.ymlcron (replaced by publish-time check)RELEASE.mdto document the two-step process and ordering rulesType of change
Checklist
Testing
N/A — CI workflow changes are validated by GitHub Actions on trigger; no local unit tests apply.
Additional Notes
This is part of a coordinated change across the Moldflow monorepo and the public API repo. The monorepo side consumes the wheel from GitHub Releases via a CMake download step, so the GitHub Release must be created first, and PyPI publishing follows as a separate manual step once the monorepo release is confirmed.