fix: remove blocking ICMP call and get disconnected ping from measuring server status round-trip#2824
Merged
Conversation
…ng server status round-trip
jcsnider
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ICMP ping introduced to get ping values while not actively connected to a server is a blocking call and blocks for the full length of the timeout (5000ms).
If the server is down or does not respond to ICMP, this means a 5 second block on the main thread.
This PR strips that out, and uses an approximation based on the round-trip time of
ServerStatusRequestPacketandServerStatusResponsePacketto calculate a ping value that can be displayed until a connection is actually established.