feat: use passphrase for validator registration/update#199
Merged
Conversation
# Conflicts: # .gitignore # composer.json # composer.lock # src/Enums/Fees.php # src/Enums/TypeGroup.php # src/Enums/Types.php # src/Helpers.php # src/Identities/Address.php # src/Identities/PrivateKey.php # src/Identities/PublicKey.php # src/Identities/WIF.php # src/Transactions/Builder/AbstractTransactionBuilder.php # src/Transactions/Deserializer.php # src/Transactions/Serializer.php # src/Transactions/Types/HtlcLock.php # src/Transactions/Types/IPFS.php # src/Transactions/Types/MultiPayment.php # src/Transactions/Types/Transaction.php # src/Transactions/Types/Transfer.php # tests/Unit/Transactions/Builder/HtlcClaimTest.php # tests/Unit/Transactions/Builder/HtlcLockTest.php
…at/add-bls-passphrase
…at/add-bls-passphrase
…at/add-bls-passphrase
# Conflicts: # .php-cs-fixer.cache
…ase' into feat/implement-validator-passphrase
shahin-hq
commented
Jun 16, 2026
| { | ||
| $dataOffset = self::readUInt($bytes, $offset); | ||
| $bytesOffset = $offset + $dataOffset; | ||
| $bytesOffset = $dataOffset; |
Author
There was a problem hiding this comment.
ABI encodes dynamic-type pointers as absolute byte offsets from the start of the params buffer. decodeDynamicBytes and decodeString were computing $offset + $dataOffset, which works accidentally for the first argument ($offset = 0) but adds a spurious slot-width for every subsequent one, landing mid-data and causing a hexdec float overflow. Fix: use $dataOffset directly as the absolute position.
…ase' into feat/implement-validator-passphrase # Conflicts: # .php-cs-fixer.cache
…ase' into feat/implement-validator-passphrase
ItsANameToo
changed the title
ItsANameToo
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://app.clickup.com/t/2570579/86e1kedx0
This PR refactors validator registration/update to use passphrase instead of public key.
ts PR for reference: https://github.com/ArdentHQ/typescript-crypto/pull/76/
Checklist