Skip to content

dumpyara: fixes for dumping OPPO/OnePlus stock ROMs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akhilnarang merged 2 commits into from
Jun 29, 2026
Merged

dumpyara: fixes for dumping OPPO/OnePlus stock ROMs #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
630b6d7
utils/partitions: handle partitions ending in .bin too
muhammad23012009 Jun 29, 2026
9870711
dumpyara: encode all-files.txt in utf-8
muhammad23012009 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dumpyara/dumpyara.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from dumpyara.steps.prepare_images import prepare_images

try:
import firmware_parsers # noqa: F401

Check failure on line 18 in dumpyara/dumpyara.py

View workflow job for this annotation

GitHub Actions / pyright 

Import "firmware_parsers" could not be resolved (reportMissingImports)

_HAS_FIRMWARE_PARSERS = True
except ImportError:
Expand Down Expand Up @@ -77,7 +77,8 @@
# Create all_files.txt
LOGI("Creating all_files.txt")
(output_path / "all_files.txt").write_text(
"\n".join([str(file) for file in files_list]) + "\n"
"\n".join([str(file) for file in files_list]) + "\n",
encoding="utf-8"
)

return output_path
Expand Down
22 changes: 13 additions & 9 deletions dumpyara/utils/partitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,19 +133,23 @@ def prepare_raw_images(files_path: Path, raw_images_path: Path):
def fix_aliases(images_path: Path):
"""Move aliased partitions to their generic name."""
for alt_name, name in ALTERNATIVE_PARTITION_NAMES.items():
alt_path = images_path / f"{alt_name}.img"
alt_paths = [
images_path / f"{alt_name}.img",
images_path / f"{alt_name}.bin",
]
partition_path = images_path / f"{name}.img"

if not alt_path.exists():
continue
for alt_path in alt_paths:
if not alt_path.exists():
continue

if partition_path.exists():
LOGI(f"Ignoring {alt_name} ({name} already extracted)")
alt_path.unlink()
continue
if partition_path.exists():
LOGI(f"Ignoring {alt_name} ({name} already extracted)")
alt_path.unlink()
continue

LOGI(f"Fixing alias {alt_name} -> {name}")
move(alt_path, partition_path)
LOGI(f"Fixing alias {alt_name} -> {name}")
move(alt_path, partition_path)


def get_filename_suffixes(file: Path):
Expand Down
Loading