Allow up to three decimal places for fluids amounts#64
Open
jabou453 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ME Requester work perfectly fine when configured with millibucket amounts of fluid, but the number field unconditionally marks them as invalid because of the decimal places. This logic makes sense for items only, but fluids quantities are valid down to 0.001B (1mB).
Issue Reference
Fixes issue #41.
Proposed Changes
Add a ternary for the number of decimal places allowed. Default is kept at zero for items, but conditionally set to three for fluids (increments of 1mB) using the existing
NumberFieldmemberisFluid.This is how that looks in-game;
Additional Context
I targeted 1.20.1-forge here because that is the version the pack I play (Star Technology) is based on.
The fix cleanly applies to all versions in this repo, so it can be cherry-picked over.
I know this fix isn't critical, but I was hoping you'd at least consider adding this QoL fix.
Thank you!!