[PWGDQ] optimized the computation of match attempts in QA task#16770
Draft
aferrero2707 wants to merge 1 commit into
Draft
[PWGDQ] optimized the computation of match attempts in QA task#16770aferrero2707 wants to merge 1 commit into
aferrero2707 wants to merge 1 commit into
Conversation
The computation of the number of match attempts for each MCH track is rather heavy and the code was calling the corresponding function multiple times. The number of attempts is now computed only once and stored internally.
aferrero2707
requested review from
alibuild,
iarsene,
lucamicheletti93 and
mcoquet642
as code owners
|
O2 linter results: ❌ 0 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The computation of the number of match attempts for each MCH track is rather heavy and the code was calling the corresponding function multiple times.
The number of attempts is now computed only once and stored internally.
This gives a nice 3x speedup in the processing time for a typical 2024 Pb-Pb AO2D.