[PWGUD] Adding new task to study vector meson production per ROF#16750
Merged
Conversation
rolavick
commented
Jun 20, 2026
rolavick
commented
Collaborator
- also making few partial fixes to other UD code
|
O2 linter results: ❌ 1 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for a14ff2e at 2026-06-20 13:31: Full log here. |
amatyja
approved these changes
Jun 20, 2026
Collaborator
|
Please fix the list of includes. |
vkucera
reviewed
Jun 22, 2026
| } // ZDC info | ||
|
|
||
| // fill output table | ||
| int recoFlag = (col.flags() & dataformats::Vertex<o2::dataformats::TimeStamp<int>>::Flags::UPCMode) ? 1 : 0; |
Collaborator
There was a problem hiding this comment.
The condition has a type int, not bool.
vkucera
reviewed
Jun 22, 2026
| // accept only -B bcs | ||
| if (!bcPatternB.test(thisBC)) | ||
| return; | ||
| colTH1Pointers[Form("col/%d/colSel_H", runNumberCol)]->Fill(10); |
Collaborator
There was a problem hiding this comment.
Do not hard-code bin numbers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.