soa_config: rescope the classid low-half doc to one named pattern, drop a stale citation - #910
Conversation
…op a stale citation The doc comment landed in #909 overgeneralized in two ways an operator correction caught after merge: - It cited "the zero-fallback ladder (CLAUDE.md, locked 2026-06-13)" as live justification. This repo's dev cycle is two weeks; a doc locked a month-plus back, spanning the 2026-07-02 classid canon-high flip, is not something to cite as current authority. Replaced with a plain statement of what this parser actually does (nothing — it neither enforces nor relies on any reading of a zero half). - It presented "low half + FieldMask = CSS-style screen-region addressing" as classid's general meaning. That is one rendering pattern's reading — MedCare-rs's Redmine-style QueryColumn fieldview (crates/medcare-server/src/views/fieldview.rs) — not a property of classids or ClassView in general. Classes are not only for display; routing, storage, RBAC, and action dispatch are classid consumers too, each free to read the low half differently. Made the domain-dependence concrete with a same-bit-pattern example: 0xFFFF is a defined sentinel (Unassigned) in the ontology/concept domain per ogar_codebook::canonical_concept_domain, and carries no such meaning outside it. The parser's own behavior is unchanged — still purely structural (0x-prefixed hex fitting u32) — only the doc comment's claims about what it does or doesn't imply are corrected. Also corrected PR #909's merged description, which repeated the same two claims. Gate: 17/17 soa_config (including the shipped-example cross-check against the edited YAML) · clippy clean · fmt clean.
|
Warning Review limit reached
Next review available in: 5 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_5fa93f8e-e099-4d2b-b97c-b136e37d7f90) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53939ab8d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…t low-half Codex P2 on #910: canonical_concept_domain takes the u16 concept id that classid_canon extracts from the HIGH half under CanonHigh. A classid like 0x0F01_FFFF still routes to Geo via its canon (0x0F01); 0xFFFF sitting in the LOW half carries no ontology meaning at all. The doc presented 0xFFFF as evidence of "what the low half means in the ontology domain" — backwards, since it's a fact about the high half, uniform across every classid whose canon happens to be 0xFFFF. Reframed as a contrast instead: the HIGH half has one global, consumer-independent reading (ogar-vocab's canonical_concept_domain, which is why 0xFFFF -> Unassigned holds for ANY classid with that canon). The LOW half has no such global registry — its meaning is whatever the specific consumer (MedCare-rs's fieldview pattern, or any other classid consumer) decides, which is the actual point this doc comment is making. Gate: 17/17 soa_config · fmt clean.
2 participants
Follow-up to #909, which merged before this correction landed.
What was wrong
The classid doc comment #909 shipped overgeneralized in two ways:
CLAUDE.md, locked 2026-06-13)" as live justification for treating a zero canon as legal. This repo's dev cycle is two weeks — a doc locked over a month back, spanning the 2026-07-02 classid canon-high flip, is not something to cite as current authority. The conclusion (a zero canon is legal, not a typo signature) still holds, but not on that citation, and not as a behavioral guarantee this parser makes — it doesn't consult or enforce any reading of a zero half at all, so claiming "zero means not consulted" overstated what actually happens here.QueryColumnfieldview (crates/medcare-server/src/views/fieldview.rs) — not a property of classids orClassViewin general. Classes are not only for display: routing, storage, RBAC, and action dispatch are classid consumers too, each free to read the low half differently, or not at all.What changed
Rewrote the
classidfield doc (and the matching prose in the example YAML) to:0xFFFFis a defined sentinel (Unassigned) in the ontology/concept domain perogar_codebook::canonical_concept_domain— the same bit pattern carries no such meaning outside that domain.The parser's actual behavior is unchanged (still purely structural:
0x-prefixed hex fitting u32) — only the doc comment's claims about what it does or implies are corrected.Also corrected #909's merged description, which repeated the same two claims.
Gate
17/17
soa_config(including the shipped-example cross-check against the edited YAML) · clippy clean · fmt clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01NMeiLmtDKhomJNSo2ecbJw
Generated by Claude Code