board: post-merge entries for #881/#882/#883 + re-scope the removed statistics work as C1b - #884
Merged
Merged
Conversation
…tatistics work as C1b Post-merge hygiene, written on merge rather than as later cleanup (the delay is the anti-pattern the arc's own recovery note documents). Arc entries for #881, #882 and #883, plus the matching LATEST_STATE entry. The #883 entry records the ruling in its canonical wording: #879 is the complete and independent production phase-progression path; KanbanActor has no assigned architectural responsibility and its presence designates it as the future home of nothing. It also records the separation that must not blur -- MulAdvance and drive_mul_advance are legacy actor-message WRAPPERS, not the canonical MUL reasoning engine; gate_decision_i4 is independent, consumed directly by the #879 path, and not deprecated; the NARS recipes and awareness rung ladder are separate and untouched. The spawn inventory is recorded as deletion-impact evidence and a removal work-list only, with no architectural legitimacy. Restores the statistics scope that was deliberately removed from #883, now as its own deliverable rather than mixed into a legacy-surface correction: - C1 result: jc is in-tree; reliability.rs ships pearson / spearman / cronbach_alpha / icc (Icc2_1, Icc3_1), plus jirak.rs for the C4 noise floors. phi = pearson on two binary variables and KR-20 = alpha on dichotomous items, so those two renames are reporting work, not new math. kappa is absent from jc entirely -- the real gap, and it blocks D3's fusion falsifier. - C1b: kappa + McDonald's omega + effect size (Effektstärke), ADDITIVE ONLY. pearson/spearman/cronbach_alpha/icc stay untouched; any diff editing an existing jc statistic is an automatic reject, independent of merit. - C2 corrected: kappa is a SEPARATE estimator, not a renamed ICC. ICC stays ICC for the non-binary escalation only. No code, no runtime behaviour, no actor content. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3RyLEbuNSHxxB3NTTrGki
|
Warning Review limit reached
Next review available in: 3 seconds You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_28771796-e007-4a26-9cb7-505c06a0de52) |
…itive-only Operator corrections, three rounds: 1. Effect size means **R, the r-family** (correlation / variance explained) — R, R-squared, eta-squared, phi. Cohen's d is explicitly OUT of this deliverable; if a mean-difference contrast is ever wanted it is calculated separately. The earlier "Effektstaerke / effect size" wording was too vague to implement against and is replaced. 2. Add **t-test** (t/df/p) and **ANOVA eta-squared** (erklaerte Varianz). The t-test is the significance companion to eta-squared, not a d-family route: it reports t/df/p and the effect size is read off eta-squared / R-squared. 3. **phi is already present in substance** — phi IS Pearson r on two binary variables, so `jc::reliability::pearson` is the arithmetic. Only a named wrapper plus the marginal-capped-ceiling caveat are new; the computation is not re-implemented. Additive constraint restated with the one carve-out the operator sanctioned: existing jc statistics keep their arithmetic, signature and semantics, and new estimators land in a new module beside them. The single permitted edit to an existing file is **visibility only** — widening reliability.rs's private helpers (mean / all_finite / average_ranks / pop_var) to pub(crate) so the new module reuses them instead of growing a second source of truth, plus the `pub mod` line. No body change, no signature change, no incidental cleanup. Touches the plan's C1b block and the STATUS_BOARD D-KIA-C1b row. No code change; D-KIA-C1b remains Queued. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3RyLEbuNSHxxB3NTTrGki
AdaWorldAPI
marked this pull request as ready for review
August 4, 2026 12:53
AdaWorldAPI
pushed a commit
that referenced
this pull request
Aug 4, 2026
#884 was itself the post-merge hygiene PR for #881/#882/#883 — and it merged without its own arc entry, reproducing one level up exactly the gap it was written to close. Writing the hygiene PR does not discharge the rule for the hygiene PR. Entry added, with that noted in it. Records what #884 locked: - The C1 audit finding: phi = pearson-on-binaries and KR-20 = alpha-on-dichotomous are the SAME computations already in jc (named wrapper + caveat only, arithmetic not re-implemented); kappa is absent and is NOT a renamed ICC — the real gap, and the one that blocks D3's fusion falsifier. - Effect size means the r-family: R, R-squared, eta-squared, phi. Cohen's d explicitly out, calculated separately if ever wanted. The t-test is the significance companion to eta-squared, not a d-family route. - ADDITIVE ONLY with one carve-out: existing jc statistics keep their arithmetic, signature and semantics; the sole permitted edit to an existing file is widening reliability.rs's private helpers to pub(crate) for reuse — visibility only. - The transport-vs-engine separation carried from #883, and that the spawn inventory carries no architectural legitimacy. Board prose only. D-KIA-C1b remains Queued. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3RyLEbuNSHxxB3NTTrGki
AdaWorldAPI
added a commit
that referenced
this pull request
Aug 4, 2026
…w-h9osnl board: post-merge arc + state entry for #884
AdaWorldAPI
pushed a commit
that referenced
this pull request
Aug 4, 2026
#881/#882/#883 merged with no arc entries. #884 closed that gap and merged without its own. #885 closed THAT gap and merged. An entry for #885 would need an entry, and so on without end: each step was the rule correctly applied, but the composition does not terminate. The recursion was invisible for three links because the rule is stated per-PR and every single application is locally correct — which is exactly what hides a divergent chain. Two earlier sessions each wrote the honest local lesson ("writing the hygiene PR does not discharge the rule for the hygiene PR") without noticing that the lesson, applied uniformly, never bottoms out. Amendment: a PR whose ENTIRE content is board hygiene for prior PRs — no type, plan, deliverable, epiphany or code — does not itself generate an arc entry; it is discharged by the entry it wrote. The test is content, not intent: does the PR change anything a future session needs the "why" for? Mixed PRs still get their entry (#884 landed hygiene AND the D-KIA-C1b re-scope; the entry exists for the re-scope half). This is a stopping rule, not a loosening. Merging three PRs with no entries at all remains a violation and the retroactive-hygiene anti-pattern is unchanged; only the degenerate tail is excluded. Consequence: #885 gets no arc entry, deliberately, and its absence is not a gap. Transferable shape recorded: a per-item obligation whose discharge is itself an item of that kind needs an explicit base case, or it is a recursion with no bottom. The cheap check is to apply a rule twice to its own output and see whether the third application says anything new. Board/doc prose only. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K3RyLEbuNSHxxB3NTTrGki
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, both board-only. No code, no runtime behaviour, no actor content.
1. Post-merge hygiene for #881, #882, #883
Written on merge rather than as later cleanup — the delay is the anti-pattern the arc's own 2026-07-27 recovery note documents. Three arc entries plus the matching
LATEST_STATEentry.The #883 entry records the ruling in its canonical wording — #879 is the complete and independent production phase-progression path; KanbanActor has no assigned architectural responsibility; its presence designates it as the future home of nothing — and, deliberately, the separation that must not blur:
The spawn inventory is recorded as deletion-impact evidence and a removal work-list only, with no architectural legitimacy. The withdrawn items (both A1 seams, the actor-owned
emit_bootstrap_intentmilestone, the planning-initiation adapter, the future actor/nudge slice, the ownership-injection framing) are listed as withdrawn with nothing substituted.2. The statistics work, re-scoped as its own deliverable
This is the material removed from #883 on the instruction not to mix a statistics roadmap into a legacy-surface correction. It returns here as C1b, not folded into anything else.
C1 result (read-only audit).
jcis in-tree atcrates/jc/;reliability.rsshipspearson,spearman,cronbach_alpha,icc(ratings, IccForm)withIcc2_1/Icc3_1, plus ajirak.rsgiving C4's noise floors a local implementation to cite.The useful finding is that two of the three renames are the same computation and one is a genuine gap:
pearsonalready computes it — reporting + marginal-ceiling caveat, no new mathcronbach_alphais the right function — naming + caveat onlyjcentirely — a different estimator, not a renamed ICC. This blocks D3's fusion falsifier.C1b — the additive-only
jcextensionjctodaypearsongives r for one criterion pair; multi-criterion R / R² is newjc::reliability::pearsonand is not re-implemented.Effect size = the r-family (R, R², η², φ). Cohen's d is explicitly out of this deliverable — calculated separately if a mean-difference contrast is ever wanted. The t-test is the significance companion to η², not a d-family smuggling route: it reports t/df/p, and effect size is read off η²/R².
C2 corrected: κ is a separate estimator, not a renamed ICC; ICC stays ICC for the non-binary escalation only. (My own C1 note had contradicted C2's original wording — fixed here.)
Test plan
Board/plan prose only. Append-only respected: new entries prepend; the one touch to an existing entry is C2's estimator-mapping correction inside the live plan, not a merged arc entry.
🤖 Generated with Claude Code
https://claude.ai/code/session_01K3RyLEbuNSHxxB3NTTrGki
Generated by Claude Code