Document ARIA mappings for boolean and node-list properties - #760
Open
blinding-pixels wants to merge 1 commit into
Open
Document ARIA mappings for boolean and node-list properties#760blinding-pixels wants to merge 1 commit into
blinding-pixels wants to merge 1 commit into
Conversation
DataTriny
requested changes
Aug 5, 2026
| /// | ||
| /// [`aria-controls`]: https://www.w3.org/TR/wai-aria-1.2/#aria-controls | ||
| (Controls, controls, set_controls, push_controlled, clear_controls), | ||
| /// The nodes that provide detailed, extended descriptions for this node. |
Member
There was a problem hiding this comment.
I feel like this documentation is too similar to the one for described_by. ARIA explains the link between the two and maybe we should do the same.
| } | ||
|
|
||
| node_id_vec_property_methods! { | ||
| /// The ordered list of this node's direct children in the tree. |
Member
There was a problem hiding this comment.
I don't know if the single word "ordered" here is enough. Maybe we should replace it by a second sentence to hammer the fact that the order must be chosen carefully as it directly influences how widgets are placed, akin to the tab index on a web page. Any idea?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the documentation work from #753 and #757 by covering two boolean properties and eight node-list properties discussed in #749.
Two of these properties,
ChildrenandRadioGroup, do not have direct ARIA equivalents. One property,Details, differs from its ARIA 1.2 equivalent becausearia-detailsreferences a single element, whileDetailscan reference multiple nodes. This difference has been documented.I ran:
cargo fmt --all -- --checkRUSTDOCFLAGS="-D warnings" cargo doc -p accesskit --no-depscargo test -p accesskitHappy to revise anything if required.