Document ARIA mappings for usize properties - #757
Merged
Conversation
DataTriny
requested changes
Aug 4, 2026
| /// equivalent: [`aria-rowindex`]. | ||
| /// | ||
| /// **Difference with ARIA:** `aria-rowindex` is one-based, while this | ||
| /// AccessKit property is zero-based. |
Member
There was a problem hiding this comment.
I think the word AccessKit here is unnecessary. Can you remove it to the other zero-based properties below?
DataTriny
requested changes
Aug 4, 2026
| /// ARIA equivalent: [`aria-setsize`]. | ||
| /// | ||
| /// **Difference with ARIA:** `aria-setsize` is set on each item, while this | ||
| /// AccessKit property is set on the container. |
Member
There was a problem hiding this comment.
Suggested change
| /// AccessKit property is set on the container. | |
| /// property is set on the container. |
Contributor
Author
|
My Pleasure. Working on the next one already should have that iopened in a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the documentation work from #753 by covering the
usizeproperties discussed in #749, using the same format established in #753.A couple of points I would particularly appreciate confirmation on:
PositionInSetdocumentation: its value must be less thanSizeOfSet, rather than less than or equal to it.SizeOfSeton the container, whereas ARIA placesaria-setsizeon each item.I ran:
cargo fmt --all -- --checkRUSTDOCFLAGS="-D warnings" cargo doc -p accesskit --no-depscargo test -p accesskit