Fix auto-detection - #8
Closed
alsldlflglhljlk wants to merge 9 commits into
Closed
Conversation
fix indent error
Contributor
|
Closing as obsolete and unsafe to merge. The proposed parser raises TypeError when modalities is absent/None, treats GRID_VISION=false (and any other non-empty string) as an explicit truthy declaration, preserves unsupported modality values, mutates the caller list, and can append duplicate image entries. The current main branch already has validated defaults and automatic capability detection. Existing smoke tests pass only because they do not exercise these cases; direct checks reproduce the failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, if
GRID_MODALITIESincludes vision orGRID_VISIONis true, then autodetect won't run. If neither is true, do autodetection.