Skip to content

fix grain_worker_count max value#4335

Open
aireenmei wants to merge 1 commit into
mainfrom
aireen/row_sharding_fix
Open

fix grain_worker_count max value#4335
aireenmei wants to merge 1 commit into
mainfrom
aireen/row_sharding_fix

Conversation

@aireenmei

@aireenmei aireenmei commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Description

When len(data_files) < dataloading_host_count, the old way of calculating min_files_per_host gives 0, making the check on line 195 always raise for any grain_worker_count > 0. The right upper bound is files_per_host

Tests

NA

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@aireenmei aireenmei marked this pull request as ready for review July 2, 2026 01:22
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant