Avoid checkpoint work on skipped steps#4326
Open
SujeethJinesh wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cab90e8 to
1cef908
Compare
1cef908 to
1cf2be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Pathways profiler for
train.py, we see that the checkpointing logic appears to take the majority of time in a trace for Pathways, but this is due to themaybe_save_checkpointfunction misclassifying it as doing work right now. This makes reading the profile harder and is a major red herring for debugging.With this fix, it shows a more reasonable amount of work performed by the Pathways CPU node (screenshot).
This should also help avoid some of the unnecessary checkpointing related logic for other paths as well.
FIXES: b/530256100
Tests
Tested on internal cluster (details in b/529621972#comment6)
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.