Fix relative path error for compiler wrappers in fuzzer Justfiles - #3890
Open
rifatarefin wants to merge 1 commit into
Open
Fix relative path error for compiler wrappers in fuzzer Justfiles#3890rifatarefin wants to merge 1 commit into
rifatarefin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiple fuzzer
Justfilerecipes fail during thelibtask while runningjust run:Root Cause
LIBAFL_CCandLIBAFL_CXXwere defined as relative paths (e.g.,CARGO_TARGET_DIR / PROFILE_DIR / "libafl_cc"). Invokingmake -C <subdir>later in the recipe resolves the relative path from the target subdirectory instead of the project root, resulting in an invalid compiler path.Solution
Wrap compiler wrapper definition with
absolute_path()so the path remains valid regardless of working directory change:This ensures that when
make -Cchanges into other directory, the compiler path is still correct.Affected Fuzzers
inprocess/libfuzzer_libmozjpeginprocess/libfuzzer_libpng_accountinginprocess/libfuzzer_libpng_norestartinprocess/libfuzzer_libpng_tcp_managerstructure_aware/nautilus_syncTesting
After the fix,
just runcompletes successfully on all affected fuzzers without path resolution errors.