Skip to content

ci: publish PR web previews - #138

Merged
gac0812 merged 4 commits into
1024XEngineer:MVPfrom
gac0812:codex/ci-pr-web-preview-fix
Aug 1, 2026
Merged

ci: publish PR web previews#138
gac0812 merged 4 commits into
1024XEngineer:MVPfrom
gac0812:codex/ci-pr-web-preview-fix

Conversation

@gac0812

@gac0812 gac0812 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • carry the PR Web Preview workflow and nested Expo base-path configuration on top of the corrected frontend dependency graph
  • deploy static preview builds under PR-specific GitHub Pages paths and clean them up when PRs close

Dependency

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two concrete issues in the preview workflow and Android network configuration; details are attached inline.

jobs:
deploy-preview:
name: Deploy web preview
if: github.event.pull_request.head.repo.full_name == github.repository

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition skips the entire job whenever the PR head repository is a fork, which includes this PR. As a result, fork PRs never export, deploy, or receive a preview comment. If fork previews are intended to be supported, use a trigger/checkout design that preserves token safety while allowing the preview; otherwise this workflow should document that limitation rather than presenting itself as a general PR preview.

}

const application = AndroidConfig.Manifest.getMainApplicationOrThrow(manifest);
application.$['android:usesCleartextTraffic'] = 'true';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting android:usesCleartextTraffic to true on the application enables plaintext HTTP for every Android build, including release builds, not just the LAN ws:// use case mentioned in the comment. This weakens the release transport security and permits other app traffic to be downgraded/intercepted. Keep cleartext disabled for release builds and scope any LAN-development exception to a debug-only configuration.

@gac0812
gac0812 merged commit d0c0111 into 1024XEngineer:MVP Aug 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant