feat(native): align latest Swift and Kotlin SDKs#45
Open
tolgahan-arikan wants to merge 6 commits into
Open
Conversation
|
Claude finished @tolgahan-arikan's task —— View job PR Review — align latest native SDKs (alpha.4)Overall this is a clean, well-scoped version-alignment PR. Native bridge changes are consistent with the existing TS contract, no backwards-compat shims, and docs/changelog are updated. A few notes below; nothing is a hard blocker except confirming the two external dependency-publish preconditions. Correctness / native bridge consistency
Auth / session / signing / tx security
Backwards-compat shims
Expo dependency policy
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.1.0-alpha.4.io.github.0xsequence:oms-client-kotlin-sdk:0.1.0-alpha.4, lower wrapper/example defaults tominSdk 24, and align Kotlin/coroutines/serialization settings.oms-client-swift-sdk0.1.0-alpha.4and align native error details with Android.OMSClientAPI and addyarn expo-example:installfor published-package or local-tarball installs.Validation
lint,lint-typecheck,build-library,build-android,build-ios, and CodeQL.yarn lint,yarn typecheck,yarn test,yarn expo-example:install, Expo typecheck, SDK example Android/iOS builds, Trails actions Android build, and Expo iOS simulator smoke test.Publishing
After merge, publish
0.1.0-alpha.4frommasterwith the alpha tag:Then verify the npm tarball and refresh the Expo example lockfile against it:
If the lockfile changes, commit the refreshed
examples/expo-example/package-lock.json.