From 33063cd7c2e9f08039c32f06fb3a519555403a58 Mon Sep 17 00:00:00 2001
From: Husni Adil Makmur <husni.adil@gmail.com>
Date: Sun, 2 Aug 2026 11:59:07 +0700
Subject: [PATCH] fix: register azure_keyvault provider so it is reachable at
 runtime

Providers register themselves from init(), so a provider is only usable
if internal/cli blank-imports it. azurekeyvault was implemented, tested
and documented but never imported, making `kind: azure_keyvault` fail
with "unknown provider kind" in every released binary.

The e2e tests missed this because they import the provider package
directly, proving the provider works but not that it is reachable.
The added test asserts registry contents against the documented kinds,
which is what actually catches this class of bug.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hmh2p2Bg6kmxxvzpFDW2WL
---
 internal/cli/providers_test.go | 61 ++++++++++++++++++++++++++++++++++
 internal/cli/root.go           |  1 +
 2 files changed, 62 insertions(+)
 create mode 100644 internal/cli/providers_test.go

diff --git a/internal/cli/providers_test.go b/internal/cli/providers_test.go
new file mode 100644
index 0000000..4b40a35
--- /dev/null
+++ b/internal/cli/providers_test.go
@@ -0,0 +1,61 @@
+package cli
+
+import (
+	"sort"
+	"testing"
+
+	"github.com/dirathea/sstart/internal/provider"
+)
+
+// documentedKinds lists every provider kind CONFIGURATION.md advertises.
+// Providers register themselves from init(), so a kind is only reachable from
+// the binary if this package blank-imports it. Keeping the list here catches
+// a provider that is implemented and tested but never wired up.
+var documentedKinds = []string{
+	"1password",
+	"aws_secretsmanager",
+	"azure_keyvault",
+	"bitwarden",
+	"bitwarden_sm",
+	"doppler",
+	"dotenv",
+	"gcloud_secretmanager",
+	"infisical",
+	"template",
+	"vault",
+}
+
+func TestAllDocumentedProvidersAreRegistered(t *testing.T) {
+	registered := make(map[string]bool)
+	for _, kind := range provider.List() {
+		registered[kind] = true
+	}
+
+	for _, kind := range documentedKinds {
+		if !registered[kind] {
+			t.Errorf("provider kind %q is documented but not registered; add a blank import to root.go", kind)
+		}
+		if _, err := provider.New(kind); err != nil {
+			t.Errorf("provider.New(%q) failed: %v", kind, err)
+		}
+	}
+}
+
+func TestNoUndocumentedProvidersAreRegistered(t *testing.T) {
+	documented := make(map[string]bool)
+	for _, kind := range documentedKinds {
+		documented[kind] = true
+	}
+
+	var extra []string
+	for _, kind := range provider.List() {
+		if !documented[kind] {
+			extra = append(extra, kind)
+		}
+	}
+
+	if len(extra) > 0 {
+		sort.Strings(extra)
+		t.Errorf("registered provider kinds missing from CONFIGURATION.md: %v", extra)
+	}
+}
diff --git a/internal/cli/root.go b/internal/cli/root.go
index f36a864..7e8ee22 100644
--- a/internal/cli/root.go
+++ b/internal/cli/root.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 
 	_ "github.com/dirathea/sstart/internal/provider/aws"
+	_ "github.com/dirathea/sstart/internal/provider/azurekeyvault"
 	_ "github.com/dirathea/sstart/internal/provider/bitwarden"
 	_ "github.com/dirathea/sstart/internal/provider/doppler"
 	_ "github.com/dirathea/sstart/internal/provider/dotenv"