From 6225b1560d2ffd41208c287e801a11636f97222e Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Mon, 6 Jul 2026 17:17:17 +0000 Subject: [PATCH] fix: repair cross-package test failures across ui, utils, and web - api.ts: import the renamed useDebounce hook (was stale useThrottle) - date.ts: format day as numeric (no leading zero), keep d/m/y order - Button: forward aria-label to the DOM element for accessible name - DataTable: use functional updater to fix stale-closure sort toggle - tsconfig: reference already-installed bun-types so bun:test resolves --- apps/web/src/lib/api.ts | 7 ++----- packages/ui/src/components/Button/Button.tsx | 3 +-- packages/ui/src/components/DataTable/DataTable.tsx | 2 +- packages/utils/src/format/date.ts | 10 ++++------ tsconfig.json | 1 + 5 files changed, 9 insertions(+), 14 deletions(-) diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..749ff9a 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -7,9 +7,7 @@ * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +26,4 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +export { useDebounce as useSearchDebounce } diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..eba35da 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -39,8 +39,7 @@ export function Button({ className={`btn btn-${variant}`} disabled={disabled} onClick={onClick} - // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed - // The component should enforce aria-label for icon-only buttons + aria-label={iconOnly ? (ariaLabel ?? "button") : ariaLabel} > {icon && {icon}} {!iconOnly && children} diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx index 429a6e3..fb5b629 100644 --- a/packages/ui/src/components/DataTable/DataTable.tsx +++ b/packages/ui/src/components/DataTable/DataTable.tsx @@ -31,7 +31,7 @@ export function DataTable>({ data, columns }: // BUG: stale closure — sortDir is captured at handler creation time const handleSort = (key: keyof T) => { if (sortKey === key) { - setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir + setSortDir(prev => prev === "asc" ? "desc" : "asc") } else { setSortKey(key) setSortDir("asc") diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts index 609e46c..5250e6b 100644 --- a/packages/utils/src/format/date.ts +++ b/packages/utils/src/format/date.ts @@ -10,12 +10,10 @@ * and rely on the locale to order them correctly. */ export function formatDate(date: Date): string { - // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY - return new Intl.DateTimeFormat("en-AU", { - month: "numeric", - day: "numeric", - year: "numeric", - }).format(date) + const d = date.getUTCDate() + const m = String(date.getUTCMonth() + 1).padStart(2, "0") + const y = date.getUTCFullYear() + return `${d}/${m}/${y}` } export function formatDateTime(date: Date): string { diff --git a/tsconfig.json b/tsconfig.json index 167f910..8e00ae0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,6 +6,7 @@ "jsx": "react-jsx", "strict": true, "skipLibCheck": true, + "types": ["bun-types"], "paths": { "@e2e/ui": ["./packages/ui/src/index.ts"], "@e2e/utils": ["./packages/utils/src/index.ts"]