ProbeGroup marked abstract with no virtual or abstract member

[jonnew]

The only thing this does is prevent direct instantiation, but I'm failing to see why:

OpenEphys.ProbeInterface.NET/OpenEphys.ProbeInterface.NET/ProbeGroup.cs

Line 12 in 00f0e05

public abstract class ProbeGroup

[bparks13]

The initial reasoning is because I intended this to be a pure base class, knowing that we were going to be creating multiple concrete classes. By marking this as abstract, it forces the creation of those classes instead of passing around an arbitrary ProbeGroup class, which could correspond to any type of probe or probe group. However, I can see that this was wrong for this repo; I was optimizing it for a specific use case (namely the bonsai-onix1 repo), instead of making it generic and usable in all scenarios. I'll remove the abstract modifier.

[jonnew]

@bparks13 If the consumer wants to specialize, they can override. Why take the option away for those that just want to use the API as is? You are forcing them to implement a whole class to use your API. I'm not sure what you mean by you feel that ProbeGroup being "arbitrary" .

Please don't make changes to this library, I'm in the middle of a large refactor (the issue was already assigned to me).