From 0f0386b6c18e6a715199f0c29b5209fe2f496872 Mon Sep 17 00:00:00 2001 From: Mark Conroy Date: Mon, 13 Oct 2025 12:19:14 +0100 Subject: [PATCH 1/3] adds strict type and return for method --- .../src/Form/LocalgovServiceContactForm.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php b/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php index 41eecdc..aa5e0c3 100644 --- a/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php +++ b/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php @@ -1,5 +1,6 @@ getValue('user')[0]['target_id']; From 9fc4f65d91018604cf7682723d9a33dd57700306 Mon Sep 17 00:00:00 2001 From: Mark Conroy Date: Mon, 13 Oct 2025 12:19:34 +0100 Subject: [PATCH 2/3] avoids variable name collision --- .../src/WorkflowNotification.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/localgov_workflows_notifications/src/WorkflowNotification.php b/modules/localgov_workflows_notifications/src/WorkflowNotification.php index f3f9624..523b27d 100644 --- a/modules/localgov_workflows_notifications/src/WorkflowNotification.php +++ b/modules/localgov_workflows_notifications/src/WorkflowNotification.php @@ -65,8 +65,8 @@ public function enqueue(ContentEntityInterface $entity, string $type): void { } if ($claimed_items) { - foreach ($claimed_items as $queue_item) { - $queue->releaseItem($queue_item); + foreach ($claimed_items as $claimed_item) { + $queue->releaseItem($claimed_item); } } From f0420accc3b41365c5f44a3cbf5356726841d4aa Mon Sep 17 00:00:00 2001 From: Mark Conroy Date: Mon, 13 Oct 2025 12:26:13 +0100 Subject: [PATCH 3/3] coding standards fix --- .../src/Form/LocalgovServiceContactForm.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php b/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php index aa5e0c3..5edcb29 100644 --- a/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php +++ b/modules/localgov_workflows_notifications/src/Form/LocalgovServiceContactForm.php @@ -1,6 +1,7 @@