Potential runtime crash in _NetWebView2_BrowserSetupWrapper if manager creation fails

[Blowcake]

Hi @ioa747,

Thanks again for the quick fix on #129!

While testing, I spotted one minor crash risk in _NetWebView2_BrowserSetupWrapper (around lines 808-820):

If _NetWebView2_CreateManager fails, it returns False. The code skips the If Not @error block, but then tries to log $oOuterWeb.BrowserWindowHandle at the end, which will crash the script.

A simple fix would be to guard it:

$MSG = " InnerWebViewWindow=" & $hInnerWebViewWindow & " BrowserWindowHandle=" & (IsObj($oOuterWeb) ? $oOuterWeb.BrowserWindowHandle : "[Not Created]")

Thanks again!

[ioa747]

Hi @Blowcake

Spot on! That is indeed a very real runtime risk.
If _NetWebView2_CreateManager or _NetWebView2_Initialize fails, $oOuterWeb won't be initialized as a proper COM object, causing a fatal "Obj/COM Error" crash when the script attempts to read $oOuterWeb.BrowserWindowHandle for logging.

Your ternary operator guard IsObj($oOuterWeb) ? ... : ... is the best way to prevent this crash and handle the missing reference safely.

While refactoring this function to apply your fix, I also noticed a secondary logic issue regarding how @error and @extended values were being tracked. In the original nested If Not @error structure, if an error occurred early on, the error values could be altered or lost by the time the code reached the end of the EndIf blocks.

To make the function completely bulletproof, I refactored the flow to capture @error immediately at the exact failure points, integrated your ternary object guard for the log string, and cleaned up the structure.

Here is the fully revised function:

Func _NetWebView2_BrowserSetupWrapper($hOuterParentWindow, ByRef $oOuterWeb, $sEventPrefix, $sProfile, ByRef $oOuterBridge, ByRef $hInnerWebViewWindow, $iX, $iY, $iW, $iH, $s_AddBrowserArgs)
    Local Const $s_Prefix = "[_NetWebView2_BrowserSetupWrapper]:" & " EventPrefix:" & $sEventPrefix & " Profile:" & $sProfile & " AddBrowserArgs:" & $s_AddBrowserArgs
    Local $ERR = 0, $EXT = 0, $RET = False, $MSG = "" ; predefined endpoint results
    
    $hInnerWebViewWindow = GUICreate("", $iW, $iH, $iX, $iY, $WS_CHILD, -1, $hOuterParentWindow)
    GUISetState(@SW_SHOW, $hInnerWebViewWindow)

    ; 1. Create Manager
    $oOuterWeb = _NetWebView2_CreateManager("", $sEventPrefix & "_Manager__", $s_AddBrowserArgs)
    If @error Then
        $ERR = @error
        $EXT = @extended
        $MSG = " CreateManager failed."
    Else
        ; 2. Initialize
        _NetWebView2_Initialize($oOuterWeb, $hInnerWebViewWindow, $sProfile, 0, 0, $iW, $iH)
        If @error Then
            $ERR = @error
            $EXT = @extended
            $MSG = " Initialize failed."
        Else
            ; 3. Get Bridge
            $oOuterBridge = _NetWebView2_GetBridge($oOuterWeb, $sEventPrefix & "_Bridge__")
            If @error Then
                $ERR = @error
                $EXT = @extended
                $MSG = " GetBridge failed."
            Else
                $RET = True
            EndIf
        EndIf
    EndIf

    ; 🚧 Fixed #130 @Blowcake 's bug using ternary operator to check if $oOuterWeb is a valid object before accessing properties
    Local $sHWndInfo = IsObj($oOuterWeb) ? $oOuterWeb.BrowserWindowHandle : "[Not Created]"
    $MSG &= " InnerWebViewWindow=" & $hInnerWebViewWindow & " BrowserWindowHandle=" & $sHWndInfo

    __NetWebView2_Log(@ScriptLineNumber, $s_Prefix & $MSG, 1, $ERR, $EXT)
    Return SetError($ERR, $EXT, $RET)
EndFunc   ;==>_NetWebView2_BrowserSetupWrapper

Thank you once again for your fantastic work and code quality auditing.
It's making the framework incredibly robust!

Best regards