From e40c30ccb0ff302701568dbc643e2598b4acb913 Mon Sep 17 00:00:00 2001 From: Fiona Date: Tue, 18 Aug 2026 07:17:13 -0700 Subject: [PATCH] fix(cronet): pin the test-only cronet-api dependency The module's tests compiled against "org.chromium.net:cronet-api:+", so every build resolved whatever version Chromium had published most recently. The latest release changed the Proxy and ProxyOptions constructors to private, which broke compilation of this module's tests and with it the release pipeline, without any change in this repository. The dependency is now pinned to 143.7445.0, the newest version whose Proxy API matches what the tests exercise. A test-compile classpath that shifts on its own has no place in a release build: version bumps should be deliberate. --- integrations/dd-sdk-android-cronet/build.gradle.kts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/integrations/dd-sdk-android-cronet/build.gradle.kts b/integrations/dd-sdk-android-cronet/build.gradle.kts index 2bd6f1cc96..d49cc7aa4c 100644 --- a/integrations/dd-sdk-android-cronet/build.gradle.kts +++ b/integrations/dd-sdk-android-cronet/build.gradle.kts @@ -51,8 +51,10 @@ dependencies { implementation(project(":features:dd-sdk-android-rum")) unmock(libs.robolectric) - // Trying to add most recent lib version in order to test the instrumentation, see CronetApiInstrumentationTest - testImplementation("${libs.cronetApi.get().module}:+") + // The tests exercise the newer Proxy API absent from the compile-time cronet version. + // Pinned, not "+": a floating version resolves to whatever Chromium ships next and + // has already broken this module's compilation once. + testImplementation("${libs.cronetApi.get().module}:143.7445.0") testImplementation(testFixtures(project(":dd-sdk-android-core"))) testImplementation(testFixtures(project(":dd-sdk-android-internal"))) testImplementation(testFixtures(project(":features:dd-sdk-android-rum")))