From b3ae408613706675c99cdca08c172a87fbe1c4ed Mon Sep 17 00:00:00 2001 From: VicenteSotoArmijo Date: Wed, 19 Aug 2026 15:04:26 -0400 Subject: [PATCH] fix(client): pass request options as keyword arguments http.rb 6 made the verb methods keyword-only, so passing the options hash positionally raises ArgumentError on every request the SDK makes. Splatting it keeps working on http.rb 5, so consumers can stay on either major. The dev lock moves to http 6.0.4 and webmock 3.26.2 (the release that added http.rb 6 support to its adapter) so CI runs against the version that used to break. --- Gemfile.lock | 43 ++++++++++++--------------------------- lib/fintoc/base_client.rb | 2 +- 2 files changed, 14 insertions(+), 31 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 1e5b33a..740b740 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -38,16 +38,16 @@ GEM securerandom (>= 0.3) tzinfo (~> 2.0, >= 2.0.5) uri (>= 0.13.1) - addressable (2.8.7) - public_suffix (>= 2.0.2, < 7.0) + addressable (2.9.0) + public_suffix (>= 2.0.2, < 8.0) ast (2.4.3) base64 (0.3.0) benchmark (0.4.1) - bigdecimal (3.2.2) + bigdecimal (4.1.2) builder (3.3.0) concurrent-ruby (1.3.5) connection_pool (2.5.3) - crack (1.0.0) + crack (1.0.1) bigdecimal rexml crass (1.0.6) @@ -58,27 +58,12 @@ GEM drb (2.2.3) erb (5.0.2) erubi (1.13.1) - ffi (1.17.2) - ffi (1.17.2-aarch64-linux-gnu) - ffi (1.17.2-aarch64-linux-musl) - ffi (1.17.2-arm-linux-gnu) - ffi (1.17.2-arm-linux-musl) - ffi (1.17.2-arm64-darwin) - ffi (1.17.2-x86_64-darwin) - ffi (1.17.2-x86_64-linux-gnu) - ffi (1.17.2-x86_64-linux-musl) - ffi-compiler (1.3.2) - ffi (>= 1.15.5) - rake - hashdiff (1.2.0) - http (5.3.1) - addressable (~> 2.8) + hashdiff (1.2.1) + http (6.0.4) http-cookie (~> 1.0) - http-form_data (~> 2.2) - llhttp-ffi (~> 0.5.0) - http-cookie (1.0.8) + llhttp (~> 0.6.1) + http-cookie (1.1.6) domain_name (~> 0.5) - http-form_data (2.3.0) i18n (1.14.7) concurrent-ruby (~> 1.0) io-console (0.8.1) @@ -89,9 +74,7 @@ GEM json (2.13.2) language_server-protocol (3.17.0.5) lint_roller (1.1.0) - llhttp-ffi (0.5.1) - ffi-compiler (~> 1.0) - rake (~> 13.0) + llhttp (0.6.2) logger (1.7.0) loofah (2.24.1) crass (~> 1.0.2) @@ -133,7 +116,7 @@ GEM psych (5.2.6) date stringio - public_suffix (6.0.2) + public_suffix (7.0.5) racc (1.8.1) rack (3.2.0) rack-session (2.1.1) @@ -159,14 +142,14 @@ GEM thor (~> 1.0, >= 1.2.2) zeitwerk (~> 2.6) rainbow (3.1.1) - rake (13.3.0) + rake (13.4.2) rdoc (6.14.2) erb psych (>= 4.0.0) regexp_parser (2.11.2) reline (0.6.2) io-console (~> 0.5) - rexml (3.4.2) + rexml (3.4.4) rspec (3.13.1) rspec-core (~> 3.13.0) rspec-expectations (~> 3.13.0) @@ -233,7 +216,7 @@ GEM useragent (0.16.11) vcr (6.3.1) base64 - webmock (3.25.1) + webmock (3.26.2) addressable (>= 2.8.0) crack (>= 0.3.2) hashdiff (>= 0.4.0, < 2.0.0) diff --git a/lib/fintoc/base_client.rb b/lib/fintoc/base_client.rb index a011a1a..011f288 100644 --- a/lib/fintoc/base_client.rb +++ b/lib/fintoc/base_client.rb @@ -122,7 +122,7 @@ def make_request( request_client = request_client.headers('Idempotency-Key' => idempotency_key) end - request_client.send(method, url, parameters) + request_client.send(method, url, **parameters) end def params(method, **kwargs)