From b8550951a40b3165ba3eb3a29d51d0193bfbff5e Mon Sep 17 00:00:00 2001 From: Jeremy Daer Date: Mon, 3 Aug 2026 21:17:44 -0700 Subject: [PATCH] Point two comments at functions that exist MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit accountwide.go referred readers to filterTodosByAssignees, which is not a function in this repository — the project-scoped assignee note lives in listTodosInList. Point there, and say what the note actually says so the reference is useful without following it. The second is mine from #612: I renamed rejectEmptyTaskFilterValues to validateTaskFilterValues when it took on the --due token check, and left its doc comment naming the old function. --- internal/commands/accountwide.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/internal/commands/accountwide.go b/internal/commands/accountwide.go index 668c7dce..949dbb59 100644 --- a/internal/commands/accountwide.go +++ b/internal/commands/accountwide.go @@ -191,15 +191,17 @@ func accountWideCapNotice(capped bool, meta basecamp.ListMeta, count int, plural // algorithm untouched; the number of requests it takes is a property of the // result, not of the filter. // -// Project-scoped --assignee is a different animal — see the note on -// filterTodosByAssignees. +// Project-scoped --assignee is a different animal: that endpoint has no +// assignee parameter, so the flag is applied client-side over an unlimited +// fetch. See the note in listTodosInList (internal/commands/todos.go). // dueFilterValues are the tokens --due accepts. These are categories, not // dates: internal/dateparse is deliberately not involved, since "overdue" is // not a date and "with" is not a date range. var dueFilterValues = []string{"with", "without", "overdue"} -// rejectEmptyTaskFilterValues refuses an explicitly empty --due or --assignee. +// validateTaskFilterValues refuses an explicitly empty --due or --assignee, and +// an unknown --due token. // // Every other check in this file tests the flag's *value*, which makes `--due=` // indistinguishable from never passing --due: the project-scoped guard stops