Merge pull request #150 from ToolboxAid/PR_26175_ALFA_018-alfa-idea-board-polish-consolidation

PR_26175_ALFA_018: consolidate Alfa Idea Board polish runtime changes

Author: ToolboxAid

assets/toolbox/idea-board/js/index.js

@@ -129,6 +129,10 @@ function previousStatusForRestore(record) {
     : "Refining";
 }
 
+function isEditableStatus(status) {
+  return editableStatusOptions.includes(status);
+}
+
 function rememberPreviousStatus(record) {
   if (record.status !== "Archived") {
     record.previousStatus = record.status;
@@ -436,7 +440,7 @@ function saveIdeaRow(root, row) {
   const idea = row.querySelector("[data-idea-board-idea-input]")?.value.trim();
   const pitch = row.querySelector("[data-idea-board-pitch-input]")?.value.trim();
   const status = row.querySelector("[data-idea-board-idea-status-input]")?.value;
-  if (!idea || !pitch || !status) {
+  if (!idea || !pitch || !isEditableStatus(status)) {
     updateStatus(root, "Enter an idea, pitch, and status before saving.");
     return;
   }

docs_build/dev/reports/PR_26175_ALFA_018-alfa-idea-board-polish-consolidation.md

@@ -0,0 +1,60 @@
+# PR_26175_ALFA_018 - Alfa Idea Board Polish Consolidation
+
+## Executive Summary
+
+PASS - Consolidated the remaining current-main-safe Alfa Batch D Idea Board status dropdown guard.
+
+Current `main` already contained the #114, #115, and #116 structural work: the status filter is in the left accordion, the Idea Board parent table no longer has the Updated column, idea labels wrap, editable status dropdowns list only `New`, `Exploring`, `Refining`, and `Ready`, and status filters list `New`, `Exploring`, `Refining`, `Ready`, `Project`, and `Archived`.
+
+This PR adds a runtime save guard so stale or injected editable dropdown values cannot persist non-editable statuses such as `Project` or `Archived`.
+
+## Runtime Files Changed
+
+| File | Change |
+| --- | --- |
+| `assets/toolbox/idea-board/js/index.js` | Adds an editable-status validation helper and rejects add/edit saves when the submitted status is not one of the editable statuses. |
+| `tests/playwright/tools/IdeaBoardTableNotes.spec.mjs` | Adds focused coverage that injects a stale `Project` option into the editable row and verifies it cannot create an Idea Board row. |
+
+## Source PR Coverage
+
+| Source PR | Batch D Area | Current-Main Resolution |
+| --- | --- | --- |
+| #114 | Idea Board cleanup | Already present on current main; Game Hub changes were not touched. |
+| #115 | Status filter table polish | Already present on current main; no Updated column, wrapped idea labels, themed status filters. |
+| #116 | Editable status dropdown fix | Present and hardened by this PR with save-path validation. |
+
+## Requirement Checklist
+
+| Requirement | Status | Notes |
+| --- | --- | --- |
+| Start from `main` | PASS | `main` was checked, pulled, clean, and synced before branch creation. |
+| Hard stop if branch/worktree/sync invalid | PASS | Branch `main`, clean worktree, local/origin sync `0 0` confirmed after pull. |
+| Read all Project Instructions | PASS | All files under `docs_build/dev/ProjectInstructions/` were read before edits. |
+| Implement current-main-safe Batch D runtime changes | PASS | Added runtime validation for editable-only Idea Board statuses. |
+| Editable statuses limited to New/Exploring/Refining/Ready | PASS | UI already did this; save path now enforces it. |
+| Filter statuses include Project and Archived | PASS | Existing filter behavior preserved. |
+| Preserve Game Hub changes | PASS | No Game Hub files changed. |
+| Do not change status bar work | PASS | Status bar diff check was empty. |
+| Do not install Chromium | PASS | Chromium was not installed. |
+| Required reports and ZIP | PASS | Reports generated and delta ZIP created under `tmp/`. |
+
+## Validation Lane
+
+| Command | Status | Result |
+| --- | --- | --- |
+| `node --check assets/toolbox/idea-board/js/index.js` | PASS | JavaScript syntax valid. |
+| `node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs` | PASS | Test file syntax valid. |
+| `git diff --check -- assets/toolbox/idea-board/js/index.js tests/playwright/tools/IdeaBoardTableNotes.spec.mjs` | PASS | Exit code 0; Git emitted a non-blocking CRLF warning for the test file. |
+| `git diff -- toolbox/game-hub/game-hub.js toolbox/game-hub/index.html assets/theme-v2/css/status.css assets/theme-v2/js/toolbox-status-bar.js tests/playwright/tools/ToolboxSelectedGameStatusBar.spec.mjs` | PASS | Empty diff; Game Hub and status bar work untouched. |
+| `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --workers=1 --reporter=line --timeout=30000` | BLOCKED | Browser executable missing at `C:\Users\davidq\AppData\Local\ms-playwright\chromium-1217\chrome-win64\chrome.exe`; Chromium was not installed per instruction. |
+
+## Manual Validation Notes
+
+- Compared GitHub PR #114, #115, and #116 metadata and patches against current main.
+- Confirmed the historical `toolbox/idea-board/index.js` path has moved on current main to `assets/toolbox/idea-board/js/index.js`.
+- Confirmed current main already preserves the Batch D status filter/table/dropdown shape.
+- Confirmed this PR does not modify `toolbox/game-hub/*`, `assets/theme-v2/css/status.css`, `assets/theme-v2/js/toolbox-status-bar.js`, or status bar Playwright coverage.
+
+## Branch Validation
+
+PASS - Work began from clean, synced `main`; implementation was made on `PR_26175_ALFA_018-alfa-idea-board-polish-consolidation`.

docs_build/dev/reports/codex_changed_files.txt

@@ -1,5 +1,5 @@
-docs_build/dev/reports/PR_26175_ALFA_017-alfa-game-hub-interactions-consolidation.md
+assets/toolbox/idea-board/js/index.js
+docs_build/dev/reports/PR_26175_ALFA_018-alfa-idea-board-polish-consolidation.md
 docs_build/dev/reports/codex_changed_files.txt
 docs_build/dev/reports/codex_review.diff
-tests/playwright/tools/GameHubMockRepository.spec.mjs
-toolbox/game-hub/game-hub.js
+tests/playwright/tools/IdeaBoardTableNotes.spec.mjs