Merge pull request #282 from ToolboxAid/PR_26180_OWNER_004-shared-validation-guard-fix

PR_26180_OWNER_004-shared-validation-guard-fix

Author: ToolboxAid

dev/reports/PR_26180_OWNER_004-shared-validation-guard-fix.md

@@ -0,0 +1,53 @@
+# PR_26180_OWNER_004-shared-validation-guard-fix
+
+Team: OWNER
+
+Branch: PR_26180_OWNER_004-shared-validation-guard-fix
+
+## Scope
+
+Fix the shared extraction guard regression in `toolbox/messages/messages.js` only.
+
+## Changes
+
+- Imported `isFiniteNumber` from `src/shared/number/numbers.js`.
+- Replaced two direct `Number.isFinite(...)` checks in Messages typewriter-speed handling with `isFiniteNumber(...)`.
+- Preserved the existing numeric conversion, fallback, and validation behavior.
+
+## Validation Results
+
+| Command | Result | Notes |
+| --- | --- | --- |
+| `node --check toolbox/messages/messages.js` | PASS | Syntax check passed |
+| `node dev/tools/toolbox-dev/checkSharedExtractionGuard.mjs` | PASS | Shared extraction guard passed against baseline |
+| `git diff --check` | PASS | No whitespace errors |
+| `npm test` | FAIL | Guard passed, then node test runner failed on unrelated missing module `src/engine/combat/Combat.js` imported by `dev/tests/combat/Combat.test.mjs` |
+
+## Shared Guard Result
+
+The original failure is fixed:
+
+- File: `toolbox/messages/messages.js`
+- Rule: `inline-helper-clone`
+- Match: `rule:number-is-finite-usage`
+- Previous unexpected count: 2
+- Current guard status: PASS
+
+## NPM Test Blocker
+
+`npm test` passed the `pretest` shared extraction guard, then failed in the node test runner:
+
+```text
+Error [ERR_MODULE_NOT_FOUND]: Cannot find module 'src/engine/combat/Combat.js' imported from dev/tests/combat/Combat.test.mjs
+```
+
+This PR does not change combat tests or engine combat files.
+
+## Merge / Baseline Status
+
+- PR merge: BLOCKED by `npm test` failure.
+- Baseline commit: NOT CREATED because the requested condition was `If PASS`.
+
+## ZIP
+
+- `dev/workspace/zips/PR_26180_OWNER_004-shared-validation-guard-fix_delta.zip`

dev/reports/codex_changed_files.txt

@@ -1,23 +1,4 @@
-dev/reports/PR_26179_CHARLIE_022-sprites-tool-shell.md
-dev/reports/PR_26179_CHARLIE_023-sprites-toolbar-placeholders.md
-dev/reports/PR_26179_CHARLIE_024-sprites-canvas-grid.md
-dev/reports/PR_26179_CHARLIE_025-sprites-basic-drawing.md
-dev/reports/PR_26179_CHARLIE_026-sprites-palette-panel.md
-dev/reports/PR_26179_CHARLIE_027-sprites-preview-export.md
-dev/reports/PR_26179_CHARLIE_028-sprites-editor-polish.md
-dev/reports/PR_26179_CHARLIE_029-sprites-clear-reset-controls.md
-dev/reports/PR_26179_CHARLIE_030-sprites-undo-redo.md
-dev/reports/PR_26179_CHARLIE_031-sprites-picker-zoom.md
-dev/reports/PR_26179_CHARLIE_032-sprites-shape-tools.md
-dev/reports/PR_26179_CHARLIE_033-sprites-canvas-preview-sync.md
-dev/reports/PR_26179_CHARLIE_034-sprites-frame-strip.md
-dev/reports/PR_26179_CHARLIE_035-sprites-frame-editing.md
-dev/reports/PR_26179_CHARLIE_036-sprites-animation-preview.md
-dev/reports/PR_26179_CHARLIE_037-sprites-animation-export.md
-dev/reports/PR_26179_CHARLIE_038-sprites-grid-dimension-fix.md
-dev/reports/PR_26179_CHARLIE_039-sprites-color-and-zoom-fix.md
-dev/reports/PR_26179_CHARLIE_040-dev-artifact-location-cleanup.md
+dev/reports/PR_26180_OWNER_004-shared-validation-guard-fix.md
 dev/reports/codex_changed_files.txt
 dev/reports/codex_review.diff
-docs_build/dev/reports/codex_changed_files.txt
-docs_build/dev/reports/codex_review.diff
+toolbox/messages/messages.js