Skip to content

Commit c824b44

Browse files
ToolboxAidToolboxAid
committed
REVALIDATE_PR PR_26175_ALFA_048 theme v2 chevron conversion
2 parents a32c2e2 + 592f217 commit c824b44

17 files changed

Lines changed: 438 additions & 25 deletions

‎docs_build/dev/ProjectInstructions/backlog/BACKLOG_MASTER.md‎

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,31 @@ Current OWNER clarification:
194194
- [ ] Charlie - Browser validation hardening
195195
- [ ] Charlie - Remaining test relocation audit
196196
- [ ] Charlie - Compliance baseline freeze
197-
- [ ] Charlie - System Health improvements
197+
- [x] Charlie - System Health v1 complete
198+
- Completion reference: GitHub PR #158.
199+
- Completed slices:
200+
- [x] CHARLIE_012 Runtime Health
201+
- [x] CHARLIE_013 Service Health Dashboard
202+
- [x] CHARLIE_014 Configuration Summary
203+
- [x] CHARLIE_015 Manual Health Actions
204+
- [x] CHARLIE_016 Scheduled Health Monitoring Foundation
205+
- [x] CHARLIE_017 Health Notifications Foundation
206+
- [x] CHARLIE_018 Health API Contract Cleanup
207+
- [x] CHARLIE_019 Environment Capabilities
208+
- [x] CHARLIE_020 Admin API Registry
209+
- [x] CHARLIE_021 Runtime Feature Flags
210+
- [x] CHARLIE_022 Admin Health Test Suite
211+
- [x] CHARLIE_023 System Health Documentation
212+
- [x] CHARLIE_024 Operational Documentation
213+
- Future enhancements only:
214+
- scheduler execution engine
215+
- outbound notifications
216+
- external alert delivery
217+
- provider telemetry
218+
- charts and metrics
219+
- log viewer
220+
- operational automation
221+
- observability integrations
198222
- [ ] Charlie - Infrastructure dashboard
199223
- [ ] Charlie - Environment validation
200224

‎docs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_manual-validation-notes.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22

33
- Confirmed scoped CSS scan returns no old chevron image masks, clip-path triangles, or currentColor gradient chevrons in accordion.css, panels.css, and tables.css.
44
- Confirmed Theme V2 SVG registry helper creates CSS-backed span icons with no inline SVG.
5-
- Confirmed required chevron assertions in the Idea Board test progressed before the later Game Hub expanded-row failure.
6-
- Did not merge ALFA_048 because branch validation is FAIL.
5+
- Confirmed Idea Board chevrons update through the registry-backed helper and the full Idea Board lane passes after ALFA_051.
6+
- Confirmed status bar/tool display mode behavior still passes in the required status bar lane.

‎docs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_report.md‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,12 @@
33
## Summary
44
- Added a shared Theme V2 icon module and CSS registry surface for SVG-backed icons.
55
- Converted vertical accordion, tool display mode, horizontal column toggle, and Idea Board row chevrons away from CSS-drawn gradients/clip-paths and old image masks.
6-
- Kept chevron controls decorative with existing accessible names and aria-expanded behavior intact.
6+
- Kept chevron controls decorative while preserving existing accessible names and aria-expanded behavior.
77

88
## Branch Validation
9-
FAIL
10-
11-
Required static checks and two Playwright lanes passed, but the required Idea Board Playwright lane still fails on an existing Game Hub expanded-row expectation unrelated to the chevron conversion. No merge was performed.
9+
PASS
1210

1311
## Notes
14-
- A local ignored .env from the original checkout was copied into the clean ALFA clone only to run database-dependent Playwright lanes. The file is ignored and is not included in the delta package.
15-
- The blocking Idea Board assertion is at tests/playwright/tools/IdeaBoardTableNotes.spec.mjs:419: it expects 3 [data-game-expanded-row] rows after opening a Game Hub project; current Game Hub renders 2 child rows: source-idea and readiness-output.
12+
- Revalidated after PR_26175_ALFA_051 was merged into main.
13+
- ALFA_051 resolved the stale Idea Board cross-flow row-count expectation that previously blocked this branch.
14+
- A local ignored .env from the original checkout was used only to run database-dependent Playwright lanes. It is ignored and is not included in the delta package.

‎docs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_requirements-checklist.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@
88
- PASS: No inline SVG blocks added to page HTML.
99
- PASS: No inline styles, style blocks, or page-local CSS added.
1010
- PASS: No old gfs-chevron up/down mask-image usage remains in scoped active component CSS.
11-
- FAIL: Full required validation lane is blocked by the pre-existing Game Hub row-count assertion in IdeaBoardTableNotes.spec.mjs.
11+
- PASS: Full required validation lane is green after ALFA_051.

‎docs_build/dev/reports/PR_26175_ALFA_048-theme-v2-chevron-conversion_validation-lane.md‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@
77

88
## Playwright
99
- PASS: npx playwright test tests/playwright/tools/ThemeV2SvgIconRegistry.spec.mjs --workers=1 (7 passed)
10-
- FAIL: npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --workers=1 (3 passed, 1 failed after local .env was provided)
11-
- Failure: tests/playwright/tools/IdeaBoardTableNotes.spec.mjs:419 expected 3 [data-game-expanded-row] rows, received 2.
12-
- Observed rows: source-idea and readiness-output.
13-
- PASS: npx playwright test tests/playwright/tools/ToolboxSelectedGameStatusBar.spec.mjs --workers=1 (7 passed after clearing stale Playwright artifact output from a prior timeout)
10+
- PASS: npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --workers=1 (4 passed)
11+
- PASS: npx playwright test tests/playwright/tools/ToolboxSelectedGameStatusBar.spec.mjs --workers=1 (7 passed)
1412

1513
## Pattern Scan
1614
- PASS: rg -n "gfs-chevron-(up|down)\.svg|clip-path: polygon|linear-gradient\(45deg.*currentColor|linear-gradient\(135deg.*currentColor" assets/theme-v2/css/accordion.css assets/theme-v2/css/panels.css assets/theme-v2/css/tables.css
1715

1816
## Branch Validation
19-
FAIL: Required Idea Board lane is not green.
17+
PASS

‎docs_build/dev/reports/PR_26175_ALFA_051-idea-board-game-hub-row-expectation_manual-validation-notes.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# PR_26175_ALFA_051-idea-board-game-hub-row-expectation Manual Validation Notes
2+
3+
- Confirmed the stale three-row expectation was limited to the Idea Board cross-flow test path.
4+
- Confirmed the updated test now passes against current Game Hub rendering.
5+
- No manual UI change was required because this PR only updates the test expectation.

‎docs_build/dev/reports/PR_26175_ALFA_051-idea-board-game-hub-row-expectation_report.md‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# PR_26175_ALFA_051-idea-board-game-hub-row-expectation Report
2+
3+
## Summary
4+
- Updated the Idea Board cross-flow Game Hub assertions to match the current expanded-row contract.
5+
- The flow now expects the two current child rows: source-idea and readiness-output.
6+
- Removed the stale expectation for a Game Summary child row from this Idea Board test path.
7+
8+
## Branch Validation
9+
PASS
10+
11+
## Scope
12+
- Test expectation only.
13+
- No runtime code changes.
14+
- No UI changes.

‎docs_build/dev/reports/PR_26175_ALFA_051-idea-board-game-hub-row-expectation_requirements-checklist.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# PR_26175_ALFA_051-idea-board-game-hub-row-expectation Requirements Checklist
2+
3+
- PASS: Align Idea Board Game Hub expanded-row expectation with current Game Hub behavior.
4+
- PASS: Preserve Source Idea child-table assertions.
5+
- PASS: Preserve Readiness Output child-table assertion.
6+
- PASS: Avoid runtime code changes.
7+
- PASS: Avoid UI changes.
8+
- PASS: Produce repo-structured delta ZIP under tmp/.

‎docs_build/dev/reports/PR_26175_ALFA_051-idea-board-game-hub-row-expectation_validation-lane.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# PR_26175_ALFA_051-idea-board-game-hub-row-expectation Validation Lane
2+
3+
## Commands
4+
- PASS: node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
5+
- PASS: npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --workers=1 (4 passed)
6+
7+
## Branch Validation
8+
PASS

‎docs_build/dev/reports/PR_26175_CHARLIE_025-system-health-backlog-closeout-branch-validation.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# PR_26175_CHARLIE_025 Branch Validation
2+
3+
- PASS: Fetched origin.
4+
- PASS: Checked out `main`.
5+
- PASS: Fast-forwarded `main` from `origin/main`.
6+
- PASS: Verified local `main` matched `origin/main` before branch creation.
7+
- PASS: Created `pr/26175-CHARLIE-025-system-health-backlog-closeout`.
8+
- PASS: Worktree was clean before edits.
9+
- PASS: No merge performed.

0 commit comments

Comments
 (0)