Merge PR_26175_ALFA_005 game hub audit findings cleanup

Merge PR_26175_ALFA_005-game-hub-audit-findings-cleanup.

Author: ToolboxAid

docs_build/dev/BUILD_PR.md

@@ -1,52 +1,60 @@
-# PR_26175_ALFA_004-game-hub-completion-status-audit
+# PR_26175_ALFA_005-game-hub-audit-findings-cleanup
 
 ## Purpose
-Audit Game Hub table workflow completion status only.
+Clean up the targeted Game Hub audit findings from `PR_26175_ALFA_004-game-hub-completion-status-audit`.
 
 ## Source Of Truth
-This `BUILD_PR.md` is the source of truth for `PR_26175_ALFA_004-game-hub-completion-status-audit`.
+This `BUILD_PR.md` is the source of truth for `PR_26175_ALFA_005-game-hub-audit-findings-cleanup`.
 
 ## Exact Scope
-- Audit the Game Hub table workflow completion state.
-- Produce `PASS`, `PARTIAL`, or `FAIL` status for every listed requirement with evidence paths.
-- Use existing product code and tests as evidence.
-- Run targeted validation for impacted Game Hub tests.
-- Create required PR-specific reports and a repo-structured delta ZIP.
+- Resolve the targeted Game Hub Playwright failures recorded by the ALFA_004 audit.
+- Keep the cleanup focused on stale or over-broad test expectations unless product code is required by validation.
+- Preserve the existing Game Hub table workflow behavior.
+- Preserve the shared toolbox selected-game status bar behavior.
+- Preserve Game Journey completion-metrics API/service behavior.
+- Do not implement unrelated product or UI changes.
+
+## ALFA_004 Findings To Clean Up
+- `tests/playwright/tools/GameHubMockRepository.spec.mjs:238`: duplicate `Open Game Hub` link strict-mode conflict after the shared toolbox status bar added its own Game Hub action.
+- `tests/playwright/tools/GameHubMockRepository.spec.mjs:257`: stale expectation that no `Game Status` label exists.
+- `tests/playwright/tools/GameHubMockRepository.spec.mjs:582`: stale guest-mode expectation that no `Game Status` label exists.
+- `tests/playwright/tools/GameHubMockRepository.spec.mjs:1019`: toolbox role-filter lane records known `500 /api/game-journey/completion-metrics` requests outside the Game Hub table workflow.
 
 ## Exact Targets
 - `docs_build/dev/BUILD_PR.md`
-- `docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_report.md`
-- `docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_validation-lane.md`
-- `docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_requirements-checklist.md`
+- `tests/playwright/tools/GameHubMockRepository.spec.mjs`
+- `docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_report.md`
+- `docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_validation-lane.md`
+- `docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_requirements-checklist.md`
 - `docs_build/dev/reports/codex_review.diff`
 - `docs_build/dev/reports/codex_changed_files.txt`
 
-## Audit Evidence Sources
-- `toolbox/game-hub/index.html`
-- `toolbox/game-hub/game-hub.js`
-- `src/dev-runtime/persistence/mock-db-store.js`
-- Impacted Game Hub Playwright specs discovered during audit.
-
 ## Out Of Scope
-- No product or UI implementation changes unless required to create audit reports.
+- No Game Hub product or UI behavior changes unless targeted validation proves they are required.
+- No Game Journey completion-metrics product/API/service changes.
 - No API/service contract changes.
-- No browser-owned product data changes.
-- No page-local CSS, inline styles, or style blocks.
+- No browser-owned product data as source of truth.
+- No silent fallbacks.
+- No inline styles, style blocks, or page-local CSS.
 - No engine core changes.
 - No `start_of_day` folder changes.
 
 ## Validation
-Run targeted impacted Game Hub validation discovered during audit.
+Run:
+
+```powershell
+npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs --workers=1
+```
 
-Also verify the audit-only change did not introduce inline styles or style blocks in the changed report/build files:
+Also verify the changed source does not introduce inline styles or style blocks:
 
 ```powershell
-rg -n "<[s]tyle|[s]tyle=" docs_build/dev/BUILD_PR.md docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_report.md docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_validation-lane.md docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_requirements-checklist.md
+rg -n "<[s]tyle|[s]tyle=" tests/playwright/tools/GameHubMockRepository.spec.mjs docs_build/dev/BUILD_PR.md docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_report.md docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_validation-lane.md docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_requirements-checklist.md
 ```
 
 ## Artifact
 Create repo-structured delta ZIP:
 
 ```text
-tmp/PR_26175_ALFA_004-game-hub-completion-status-audit_delta.zip
+tmp/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_delta.zip
 ```

docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_report.md

@@ -0,0 +1,24 @@
+# PR_26175_ALFA_005-game-hub-audit-findings-cleanup Report
+
+## Overall Status
+PASS
+
+ALFA_005 cleaned up the targeted Game Hub audit findings from ALFA_004 without changing Game Hub product UI, Game Journey API/service behavior, or repository contracts.
+
+## Cleanup Evidence
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Replace stale BUILD source of truth with ALFA_005 | PASS | `docs_build/dev/BUILD_PR.md:1` defines `PR_26175_ALFA_005-game-hub-audit-findings-cleanup`. |
+| Resolve duplicate `Open Game Hub` strict-mode finding | PASS | Deprecated-route assertion now scopes the link lookup to `main`, avoiding the shared toolbox status bar action while preserving the route check: `tests/playwright/tools/GameHubMockRepository.spec.mjs:251`. |
+| Resolve stale creator `Game Status` label finding | PASS | The create/open/delete test now verifies absence of legacy `Game Status` form controls instead of rejecting valid table/readiness text: `tests/playwright/tools/GameHubMockRepository.spec.mjs:270`. |
+| Resolve stale guest `Game Status` label finding | PASS | The guest save-blocking test uses the same legacy form-control assertion: `tests/playwright/tools/GameHubMockRepository.spec.mjs:595`. |
+| Resolve role-filter completion-metrics validation finding | PASS | Toolbox index role-filter setup now provides an explicit server API fixture for `/api/game-journey/completion-metrics`, preserving the Browser -> Server API -> Data Source response shape without changing production API behavior: `tests/playwright/tools/GameHubMockRepository.spec.mjs:213`, `tests/playwright/tools/GameHubMockRepository.spec.mjs:984`. |
+| Preserve Game Hub table workflow behavior | PASS | Cleanup is limited to Playwright selectors and route fixture setup; no Game Hub product files changed. |
+| Preserve shared toolbox status bar behavior | PASS | No status bar source or CSS files changed. The deprecated-route test now coexists with the status bar Game Hub action. |
+| Preserve Game Journey completion-metrics API/service behavior | PASS | No Game Journey API, service, or persistence files changed. The spec uses a targeted Playwright route fixture only for the toolbox role-filter lane. |
+| Avoid unrelated product/UI changes | PASS | Changed implementation file is limited to `tests/playwright/tools/GameHubMockRepository.spec.mjs`. |
+
+## Validation Summary
+- PASS: `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs --workers=1` produced 14 passed, 0 failed.
+- PASS: changed-source style scan found no inline style or style-block matches.

docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_requirements-checklist.md

@@ -0,0 +1,16 @@
+# PR_26175_ALFA_005-game-hub-audit-findings-cleanup Requirements Checklist
+
+- PASS: BUILD_PR.md was replaced with ALFA_005 as the source of truth.
+- PASS: Cleanup stayed focused on ALFA_004 Game Hub audit findings.
+- PASS: Duplicate `Open Game Hub` link strict-mode finding was resolved.
+- PASS: Stale creator-mode `Game Status` label assertion was resolved.
+- PASS: Stale guest-mode `Game Status` label assertion was resolved.
+- PASS: Toolbox role-filter completion-metrics validation finding was resolved with a targeted Playwright fixture.
+- PASS: Game Hub table workflow behavior was preserved.
+- PASS: Shared toolbox status bar behavior was preserved.
+- PASS: Game Journey completion-metrics API/service behavior was preserved.
+- PASS: No product or UI implementation files changed.
+- PASS: Targeted Game Hub validation passed.
+- PASS: Changed-source style scan passed.
+- PASS: Required reports were created.
+- PASS: Repo-structured delta ZIP was created.

docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_validation-lane.md

@@ -0,0 +1,19 @@
+# PR_26175_ALFA_005-game-hub-audit-findings-cleanup Validation Lane
+
+## Commands
+```powershell
+npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs --workers=1
+```
+
+Result: PASS, 14 passed and 0 failed.
+
+```powershell
+rg -n "<[s]tyle|[s]tyle=" tests/playwright/tools/GameHubMockRepository.spec.mjs docs_build/dev/BUILD_PR.md docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_report.md docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_validation-lane.md docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_requirements-checklist.md
+```
+
+Result: PASS, no matches.
+
+## Notes
+- The ALFA_004 validation lane reported 10 passed and 4 failed.
+- The same impacted Game Hub spec now passes completely after the scoped cleanup.
+- No product or UI implementation changes were required.

docs_build/dev/reports/codex_changed_files.txt

@@ -1,6 +1,7 @@
 docs_build/dev/BUILD_PR.md
-docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_report.md
-docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_validation-lane.md
-docs_build/dev/reports/PR_26175_ALFA_004-game-hub-completion-status-audit_requirements-checklist.md
+tests/playwright/tools/GameHubMockRepository.spec.mjs
+docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_report.md
+docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_validation-lane.md
+docs_build/dev/reports/PR_26175_ALFA_005-game-hub-audit-findings-cleanup_requirements-checklist.md
 docs_build/dev/reports/codex_changed_files.txt
 docs_build/dev/reports/codex_review.diff