Remove active metrics SQLite guard references

Author: ToolboxAid

docs_build/dev/reports/PR_26177_OWNER_057-game-journey-metrics-regression-recovery_branch-validation.md

@@ -17,3 +17,4 @@ Status: PASS
 - PASS: Tests are limited to targeted Game Journey completion metrics regression coverage.
 - PASS: Did not delete, move, overwrite, export, or migrate `tmp/local-api/game-journey-completion-metrics.sqlite`.
 - PASS: Did not start Alfa Tags PRs.
+- PASS: Final audit removed active runtime JS/MJS SQLite and `tmp/local-api` references outside the migration-only utility.

docs_build/dev/reports/PR_26177_OWNER_057-game-journey-metrics-regression-recovery_manual-validation-notes.md

@@ -5,9 +5,10 @@ Status: PASS
 ## Notes
 
 - Confirmed the repo-local `tmp/local-api/game-journey-completion-metrics.sqlite` file exists before validation.
-- Confirmed active `createGameJourneyCompletionMetricsStore({ postgresClient })` no longer resolves that retired path by default.
-- Confirmed active metrics load 14 Postgres-backed completion buckets while the retired file remains untouched.
-- Confirmed explicit `legacyDbPath` protection remains covered by the existing migration/regression test file.
+- Confirmed active `createGameJourneyCompletionMetricsStore({ postgresClient })` exposes no `legacyDbPath`.
+- Confirmed active metrics snapshots expose no `legacySqlitePath`.
+- Confirmed active metrics load 14 DB-backed completion buckets while the retired file remains untouched.
+- Confirmed active runtime JS/MJS has no SQLite or `tmp/local-api` metrics references outside the migration-only utility.
 - Confirmed the toolbox page renders neutral Creator-facing outage wording when active metrics are unavailable.
 - Confirmed the toolbox page does not render the forbidden warning string, SQLite wording, `tmp/local-api`, or Postgres internals in the simulated outage lane.
 - Confirmed no Alfa Tags PR work was started.

docs_build/dev/reports/PR_26177_OWNER_057-game-journey-metrics-regression-recovery_report.md

@@ -11,9 +11,10 @@ Recover the Game Journey completion metrics path so active Alfa and Owner work n
 ## Implementation Summary
 
 - Removed active runtime defaulting to `tmp/local-api/game-journey-completion-metrics.sqlite` in `createGameJourneyCompletionMetricsStore`.
-- Kept the explicit `legacyDbPath` guard intact for recovery/migration callers so legacy data is still protected from silent overwrite or deletion.
+- Removed active runtime `legacyDbPath` guard plumbing from the Game Journey metrics store, repository, Local API router, and Playwright test server helper.
 - Updated `toolbox/tools-page-accordions.js` to render neutral Creator-safe progress outage wording instead of backend diagnostics.
-- Added a store-level regression test proving a retired default SQLite-shaped file does not block active Postgres-backed metrics.
+- Added a store-level regression test proving a retired default SQLite-shaped file does not block or get touched by active DB-backed metrics.
+- Added a targeted guardrail test proving active runtime JS/MJS under `src`, `assets`, and `toolbox` has no SQLite or `tmp/local-api` metrics references, excluding the migration-only utility.
 - Added a focused Playwright test proving the toolbox page does not render the forbidden warning, SQLite wording, local filesystem path, or Postgres internals when metrics are unavailable.
 
 ## Reference Comparison
@@ -28,16 +29,20 @@ Recover the Game Journey completion metrics path so active Alfa and Owner work n
 - PASS: `node --check` on modified source and test files.
 - PASS: `node ./scripts/run-node-test-files.mjs tests/dev-runtime/GameJourneyCompletionMetricsStore.test.mjs tests/dev-runtime/GameJourneyCompletionMetricsMigration.test.mjs`.
 - PASS: `npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=line -g "Game Journey Local API persists completion metrics to Postgres|Toolbox renders Creator-safe Game Journey progress outage copy"`.
-- PASS: Direct proof against the actual existing `tmp/local-api/game-journey-completion-metrics.sqlite` file confirmed active Postgres metrics load 14 buckets and do not resolve a legacy path.
-- PASS: Runtime source search found no `Game Journey completion metrics unavailable` string.
-- PASS: Runtime source search found no active metrics-store default reference to `game-journey-completion-metrics.sqlite`, `GAMEFOUNDRY_GAME_JOURNEY_METRICS_DB_PATH`, or `defaultLegacySqlitePath`.
+- PASS: Direct proof against the actual existing `tmp/local-api/game-journey-completion-metrics.sqlite` file confirmed active DB metrics load 14 buckets, expose no legacy path fields, and do not touch the retired file.
+- PASS: Active runtime JS/MJS search found no SQLite, `.sqlite`, `better-sqlite`, `game-journey-completion-metrics.sqlite`, or `tmp/local-api` references outside the migration-only utility.
+- PASS: Runtime source search found no `Game Journey completion metrics unavailable` Creator-facing string.
 - PASS: `git diff --check` reported no whitespace errors. Git emitted line-ending warnings only.
 
 ## Files
 
 - `src/dev-runtime/persistence/game-journey-completion-metrics-store.mjs`
+- `src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js`
+- `src/dev-runtime/server/local-api-router.mjs`
 - `tests/dev-runtime/GameJourneyCompletionMetricsStore.test.mjs`
+- `tests/helpers/playwrightRepoServer.mjs`
 - `tests/playwright/tools/GameJourneyTool.spec.mjs`
+- `tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
 - `toolbox/tools-page-accordions.js`
 
 ## Artifact

docs_build/dev/reports/PR_26177_OWNER_057-game-journey-metrics-regression-recovery_requirement-checklist.md

@@ -11,12 +11,14 @@ Status: PASS
 - PASS: Fixed only the Game Journey completion metrics regression.
 - PASS: Did not delete, move, overwrite, export, or migrate `tmp/local-api/game-journey-completion-metrics.sqlite`.
 - PASS: Stopped active runtime from defaulting to `tmp/local-api/game-journey-completion-metrics.sqlite`.
+- PASS: Removed active runtime `legacyDbPath` SQLite guard plumbing.
 - PASS: Preserved Postgres-backed Game Journey completion metrics as the active path.
 - PASS: Ensured `toolbox/tools-page-accordions.js` cannot render `Game Journey completion metrics unavailable:`.
 - PASS: Creator-facing UI does not expose SQLite, local filesystem paths, migration/export language, or Postgres internals.
 - PASS: Did not introduce silent fallback behavior; metrics outage remains visible with neutral wording.
 - PASS: Added targeted regression tests.
 - PASS: Proved the existing legacy SQLite file does not block active metrics.
+- PASS: Proved active runtime JS/MJS has no SQLite or `tmp/local-api` metrics references outside the migration-only utility.
 - PASS: Proved the forbidden warning string is not rendered.
 - PASS: Proved Game Journey metrics still load through the active DB/API path.
 - PASS: Used targeted validation only.

docs_build/dev/reports/PR_26177_OWNER_057-game-journey-metrics-regression-recovery_validation-lane.md

@@ -6,9 +6,13 @@ Status: PASS
 
 ```powershell
 node --check src/dev-runtime/persistence/game-journey-completion-metrics-store.mjs
+node --check src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
+node --check src/dev-runtime/server/local-api-router.mjs
 node --check toolbox/tools-page-accordions.js
 node --check tests/dev-runtime/GameJourneyCompletionMetricsStore.test.mjs
+node --check tests/helpers/playwrightRepoServer.mjs
 node --check tests/playwright/tools/GameJourneyTool.spec.mjs
+node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
 ```
 
 Result: PASS
@@ -17,7 +21,7 @@ Result: PASS
 node ./scripts/run-node-test-files.mjs tests/dev-runtime/GameJourneyCompletionMetricsStore.test.mjs tests/dev-runtime/GameJourneyCompletionMetricsMigration.test.mjs
 ```
 
-Result: PASS, 2 targeted node test files passed
+Result: PASS, 2 targeted node test files passed. Includes active runtime JS/MJS SQLite reference guardrail.
 
 ```powershell
 npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=line -g "Game Journey Local API persists completion metrics to Postgres|Toolbox renders Creator-safe Game Journey progress outage copy"
@@ -26,14 +30,14 @@ npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --project=pl
 Result: PASS, 2 passed
 
 ```powershell
-node -e "import('node:fs').then(async fs=>{const [{createGameJourneyCompletionMetricsStore}, {createGameJourneyCompletionMetricsPostgresClientStub}] = await Promise.all([import('./src/dev-runtime/persistence/game-journey-completion-metrics-store.mjs'), import('./tests/helpers/gameJourneyCompletionMetricsPostgresClientStub.mjs')]); const legacy='tmp/local-api/game-journey-completion-metrics.sqlite'; if(!fs.existsSync(legacy)) throw new Error('Expected existing legacy SQLite file for regression proof'); const store=createGameJourneyCompletionMetricsStore({postgresClient:createGameJourneyCompletionMetricsPostgresClientStub()}); const metrics=await store.listMetrics(); if(store.legacyDbPath) throw new Error('Active store resolved a legacy path'); if(metrics.length!==14) throw new Error('Expected 14 active metrics'); console.log('PASS active Postgres metrics ignore existing retired legacy SQLite file');})"
+node -e "import('node:fs').then(async fs=>{const [{createGameJourneyCompletionMetricsStore}, {createGameJourneyCompletionMetricsPostgresClientStub}] = await Promise.all([import('./src/dev-runtime/persistence/game-journey-completion-metrics-store.mjs'), import('./tests/helpers/gameJourneyCompletionMetricsPostgresClientStub.mjs')]); const legacy='tmp/local-api/game-journey-completion-metrics.sqlite'; if(!fs.existsSync(legacy)) throw new Error('Expected existing retired local file for regression proof'); const before=fs.statSync(legacy).mtimeMs; const store=createGameJourneyCompletionMetricsStore({postgresClient:createGameJourneyCompletionMetricsPostgresClientStub()}); const metrics=await store.listMetrics(); const snapshot=await store.snapshot(); const after=fs.statSync(legacy).mtimeMs; if(Object.hasOwn(store, 'legacyDbPath')) throw new Error('Store exposes legacyDbPath'); if(Object.hasOwn(snapshot, 'legacySqlitePath')) throw new Error('Snapshot exposes legacySqlitePath'); if(metrics.length!==14) throw new Error('Expected 14 active metrics'); if(before!==after) throw new Error('Retired local file was touched'); console.log('PASS active DB metrics ignore and do not inspect retired local file');})"
 ```
 
 Result: PASS
 
 ```powershell
+rg -n -i "sqlite|better-sqlite|game-journey-completion-metrics\.sqlite|tmp/local-api" src assets toolbox -g "*.js" -g "*.mjs" --glob "!src/dev-runtime/persistence/game-journey-completion-metrics-migration.mjs"
 rg -n "Game Journey completion metrics unavailable" src assets toolbox --glob "!**/*.map"
-rg -n "game-journey-completion-metrics\.sqlite|GAMEFOUNDRY_GAME_JOURNEY_METRICS_DB_PATH|defaultLegacySqlitePath" src/dev-runtime/persistence/game-journey-completion-metrics-store.mjs toolbox/tools-page-accordions.js assets/toolbox/game-journey/js/index.js
 ```
 
 Result: PASS, no matches

docs_build/dev/reports/codex_changed_files.txt

@@ -6,6 +6,9 @@ docs_build/dev/reports/PR_26177_OWNER_057-game-journey-metrics-regression-recove
 docs_build/dev/reports/codex_changed_files.txt
 docs_build/dev/reports/codex_review.diff
 src/dev-runtime/persistence/game-journey-completion-metrics-store.mjs
+src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
+src/dev-runtime/server/local-api-router.mjs
 tests/dev-runtime/GameJourneyCompletionMetricsStore.test.mjs
+tests/helpers/playwrightRepoServer.mjs
 tests/playwright/tools/GameJourneyTool.spec.mjs
-toolbox/tools-page-accordions.js
+tests/playwright/tools/IdeaBoardTableNotes.spec.mjs