Skip to content

Commit 6360d73

Browse files
ToolboxAidToolboxAid
committed
Document PR022 root src deletion hard stop
1 parent 2e38e9e commit 6360d73

8 files changed

Lines changed: 341 additions & 18006 deletions

‎dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_branch-validation.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# PR_26180_OWNER_022-delete-remaining-root-src-files Branch Validation
2+
3+
- Expected branch: `PR_26180_OWNER_022-delete-remaining-root-src-files`
4+
- Actual branch: `PR_26180_OWNER_022-delete-remaining-root-src-files`
5+
- Branch validation: PASS
6+
- Worktree at branch start: clean after removal of previous PR022 hard-stop artifacts
7+
- Current action: HARD STOP report artifacts only
8+
- Source files modified: none

‎dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_manual-validation-notes.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# PR_26180_OWNER_022-delete-remaining-root-src-files Manual Validation Notes
2+
3+
- Reviewed current Project Instructions version `2026.06.28.021`.
4+
- Confirmed canonical report path is `dev/reports/` and ZIP path is `dev/workspace/zips/`.
5+
- Confirmed current branch is `PR_26180_OWNER_022-delete-remaining-root-src-files`.
6+
- Confirmed 65 tracked root `src` files remain before attempted deletion.
7+
- Confirmed active references still point to root `src/shared` from dev tests, validation scripts, and tooling baselines.
8+
- No runtime, UI, API, database, product, `www/`, `api/`, or source files were modified.
9+
- Manual recommendation: create a follow-up migration PR that updates the active tests/scripts/tooling baselines away from root `src/shared` before deleting the remaining files.
10+
11+
- Final `git diff --check` and `git diff --cached --check`: PASS.
12+
- Final `npm run validate:canonical-structure`: PASS.
13+
- Targeted root `src` scan still reports active references and remains the hard-stop blocker.

‎dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_report.md‎

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
# PR_26180_OWNER_022-delete-remaining-root-src-files Hard Stop Report
2+
3+
## Outcome
4+
5+
HARD STOP. No root `src/` files were deleted, archived, or moved.
6+
7+
## Reason
8+
9+
The required root `src/` reference audit found active current validation/test/tooling references that still require root `src/shared` files. The task explicitly requires a hard stop if runtime, test, package, or CI references still require root `src`.
10+
11+
## Branch
12+
13+
- Branch: `PR_26180_OWNER_022-delete-remaining-root-src-files`
14+
- HEAD: `2e38e9e31cf0b9a2718681ea95a6b8054f4a7a93`
15+
- Worktree before reports: clean
16+
- Base requested: `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`
17+
18+
## Root Src Count
19+
20+
- Before: 65 tracked files under `src/`
21+
- After: 65 tracked files under `src/`
22+
- Active reference scan matches: 1284
23+
24+
## High-Signal Evidence
25+
26+
- `dev\tests\shared\InMemoryProjectDataStore.test.mjs:14:} from "../../../src/shared/contracts/projectDataStoreContract.js";`
27+
- `dev\tests\tools\ToolManifestBoundary.test.mjs:11: "www/src/shared/schemas/tools/palette-browser.schema.json",`
28+
- `dev\scripts\validate-json-contracts.mjs:499: return `www/src/shared/schemas/tools/${normalized}.schema.json`;`
29+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3100: "file": "www/src/shared/color/color.js",`
30+
- `dev\tools\toolbox-dev\checkBoundaryHardeningGuard.mjs:16: ['src/shared/', 'shared'],`
31+
- `dev\tests\shared\ContractIndexValidation.test.mjs:59: const actualRootContractFiles = fs.readdirSync(resolvePath("src/shared/contracts"))`
32+
- `dev\tests\validation\samples.shared.boundaries.report.json:2: "$schema": "../../../src/shared/schemas/samples/sample.tool-payload.schema.json",`
33+
- `dev\scripts\validate-json-contracts.mjs:653: const gameManifestSchemaPath = "src/shared/schemas/game.manifest.schema.json";`
34+
- `dev\scripts\validate-json-contracts.mjs:665: errors.push("src/shared/schemas/game.manifest.schema.json not found");`
35+
- `dev\scripts\validate-json-contracts.mjs:706: if (!schemaPath.startsWith("www/src/shared/schemas/tools/") || !schemaPath.endsWith(".schema.json")) {`
36+
- `dev\tests\validation\samples.runtime.validation.report.json:2: "$schema": "../../../src/shared/schemas/samples/sample.tool-payload.schema.json",`
37+
- `dev\tests\validation\samples.curriculum.validation.json:2: "$schema": "../../../src/shared/schemas/samples/sample.tool-payload.schema.json",`
38+
- `dev\tests\fixtures\workspace-v2\uat.manifest.json:2: "$schema": "src/shared/schemas/game.manifest.schema.json",`
39+
- `dev\tests\fixtures\workspace-v2\uat.manifest.json:17: "$schema": "src/shared/schemas/tools/palette-manager-v2.schema.json",`
40+
- `dev\tests\fixtures\workspace-v2\uat.manifest.json:59: "$schema": "src/shared/schemas/tools/asset-manager-v2.schema.json",`
41+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3105: "file": "src/shared/contracts/auditEventContract.js",`
42+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3110: "file": "src/shared/contracts/backupSnapshotContract.js",`
43+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3115: "file": "src/shared/contracts/collaborationRoleContract.js",`
44+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3120: "file": "src/shared/contracts/creatorProfileContract.js",`
45+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3125: "file": "src/shared/contracts/downloadGrantContract.js",`
46+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3130: "file": "src/shared/contracts/entitlementContract.js",`
47+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3135: "file": "src/shared/contracts/installReceiptContract.js",`
48+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3140: "file": "src/shared/contracts/libraryItemContract.js",`
49+
- `dev\tools\toolbox-dev\checkSharedExtractionGuard.baseline.json:3145: "file": "src/shared/contracts/marketplaceListingContract.js",`
50+
51+
## Targeted Validation Evidence
52+
53+
- `git diff --check`: PASS before report generation.
54+
- `npm run validate:canonical-structure`: PASS.
55+
- `node ./dev/scripts/run-node-test-files.mjs dev/tests/shared/InMemoryProjectDataStore.test.mjs dev/tests/tools/ToolManifestBoundary.test.mjs dev/tests/shared/ContractIndexValidation.test.mjs`: FAILED.
56+
- `InMemoryProjectDataStore.test.mjs`: PASS.
57+
- `ToolManifestBoundary.test.mjs`: PASS.
58+
- `ContractIndexValidation.test.mjs`: FAILS on missing legacy `src/shared/contracts/replayContracts.js`.
59+
60+
## Decision
61+
62+
The PR stopped before deleting or archiving remaining root `src` files. The next scoped PR should first migrate or retire the active validation/test/tooling dependencies that still point at root `src/shared`, then retry root `src` deletion only after `git ls-files -- src` and active reference scans prove it is safe.
63+
64+
## Files Changed By This Outcome
65+
66+
Reports only. No runtime, API, UI, database, or product files were modified.

‎dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_requirement-checklist.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# PR_26180_OWNER_022-delete-remaining-root-src-files Requirement Checklist
2+
3+
| Requirement | Status | Notes |
4+
|---|---:|---|
5+
| Work only on remaining tracked files under root `src/` | PASS | Audit inspected tracked `src/` files only. |
6+
| Do not touch `dev/workspace/generated/tool-images/**` | PASS | Protected developer workspace path was not touched. |
7+
| Preserve no root `src` file unless active refs prove it required | HARD STOP | Active refs still prove current validation/test dependencies require root `src`. |
8+
| Delete definitely obsolete files instead of archiving | BLOCKED | Deletion would occur while active test/tooling refs remain. |
9+
| Required reference audit before delete/archive | PASS | Scan found 1284 matches. |
10+
| Stop on active runtime/test/package/CI refs requiring root `src` | PASS | Hard stop triggered. |
11+
| Report `git ls-files -- src` count before and after | PASS | Before 65, after 65. |
12+
| Produce reports under `dev/reports/` | PASS | This checklist and companion reports were generated. |
13+
| Produce ZIP under `dev/workspace/zips/` | PASS | Hard-stop ZIP generated for this outcome. |

‎dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_validation-report.md‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# PR_26180_OWNER_022-delete-remaining-root-src-files Validation Report
2+
3+
## Commands
4+
5+
| Command | Result | Notes |
6+
|---|---:|---|
7+
| `git diff --check` and `git diff --cached --check` | PASS | Ran after report generation against unstaged and staged changes. |
8+
| `npm run validate:canonical-structure` | PASS | Canonical repository structure guardrail passed after report generation. |
9+
| Targeted root `src` reference scan | HARD STOP | Found 1284 active matches outside archive/report/workspace paths. |
10+
| `node ./dev/scripts/run-node-test-files.mjs dev/tests/shared/InMemoryProjectDataStore.test.mjs dev/tests/tools/ToolManifestBoundary.test.mjs dev/tests/shared/ContractIndexValidation.test.mjs` | FAIL | First two tests passed; `ContractIndexValidation` failed on missing legacy `replayContracts.js`. |
11+
12+
## Validation Decision
13+
14+
No source deletion/archive was performed because the hard-stop condition was met before implementation.

‎dev/reports/codex_changed_files.txt‎

Lines changed: 8 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -1,72 +1,8 @@
1-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/README.md
2-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/how_to_use.html
3-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/index.html
4-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/main.js
5-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/parallaxEditor.css
6-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/images/cloud-bands.svg
7-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/images/foreground-occluder.svg
8-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/images/hero-proxy.svg
9-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/images/mountain-ridge-short.svg
10-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/images/mountain-ridge-tall.svg
11-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/images/mountain-ridge.svg
12-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/images/sky-gradient.svg
13-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/mario_style_bushes_foreground.svg
14-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/mario_style_clouds.svg
15-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/mario_style_hills.svg
16-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/mario_style_leaf_overlay.svg
17-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/mario_style_learning_level_parallax.json
18-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/mario_style_mountains.svg
19-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/mario_style_sky.svg
20-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/parallax_sample.json
21-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/sample-manifest.json
22-
D dev/archive/v1-v2/tools/old_Parallax Scene Studio/samples/tilemap_parallax_sample.json
23-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/README.md
24-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/docs/BATCH_GUARDRAIL_CONTRACT.md
25-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/docs/CONTROL_SERVICE_CONTRACTS.md
26-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/docs/OBJECT_VECTOR_STUDIO_V2_REQUIREMENTS.md
27-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/how_to_use.html
28-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/index.html
29-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/ToolStarterApp.js
30-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/bootstrap.js
31-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/controls/AccordionSection.js
32-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/controls/ActionNavControl.js
33-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/controls/InspectorControl.js
34-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/controls/PreviewPanelControl.js
35-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/controls/SourceInputControl.js
36-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/controls/StatusLogControl.js
37-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/controls/ToolStarterShellControl.js
38-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/services/ObjectVectorStudioV2SchemaService.js
39-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/js/services/ToolStateSerializer.js
40-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/playwright.config.mjs
41-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/possible.future.adds.txt
42-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/styles/toolStarter.css
43-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/README.md
44-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/palettes/vector-native-primary.palette.json
45-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/parallax/template-backdrop.parallax.json
46-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/parallax/template-backdrop.svg
47-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/tilemaps/template-arena.tilemap.json
48-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/tilemaps/template-ui.tileset.json
49-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/vectors/template-hud.vector.json
50-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/vectors/template-obstacle-large.vector.json
51-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/vectors/template-obstacle-small.vector.json
52-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/vectors/template-player.vector.json
53-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/assets/data/vectors/template-title.vector.json
54-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/config/template.project.json
55-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/docs/ROLLBACK_NOTES.md
56-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/docs/STARTER_GUIDE.md
57-
D dev/archive/v1-v2/tools/old_object-vector-studio-v2/vector-native-arcade/runtime/bootstrap.runtime.json
58-
M dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS.md
59-
M dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md
60-
M dev/build/ProjectInstructions/PROJECT_STATE.md
61-
M dev/build/ProjectInstructions/backlog/BACKLOG_MASTER.md
62-
M dev/build/ProjectInstructions/repository/canonical_repository_structure.md
63-
A dev/reports/PR_26180_OWNER_021-archive-legacy-games-samples-teardown_branch-validation.md
64-
A dev/reports/PR_26180_OWNER_021-archive-legacy-games-samples-teardown_manual-validation-notes.md
65-
A dev/reports/PR_26180_OWNER_021-archive-legacy-games-samples-teardown_report.md
66-
A dev/reports/PR_26180_OWNER_021-archive-legacy-games-samples-teardown_requirement-checklist.md
67-
A dev/reports/PR_26180_OWNER_021-archive-legacy-games-samples-teardown_validation-report.md
68-
M dev/tools/toolbox-dev/checkSharedExtractionGuard.baseline.json
69-
D www/src/tools/common/GameManifestLoader.js
70-
D www/src/tools/common/WorkspaceDirtyNotifier.js
71-
M dev/reports/codex_review.diff
72-
M dev/reports/codex_changed_files.txt
1+
dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_branch-validation.md
2+
dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_manual-validation-notes.md
3+
dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_report.md
4+
dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_requirement-checklist.md
5+
dev/reports/PR_26180_OWNER_022-delete-remaining-root-src-files_validation-report.md
6+
dev/reports/codex_changed_files.txt
7+
dev/reports/codex_review.diff
8+
dev/workspace/zips/PR_26180_OWNER_022-delete-remaining-root-src-files_HARD_STOP.zip

0 commit comments

Comments
 (0)