Skip to content

Commit 5cece49

Browse files
committed
Polish Sprite Creator editor copy
1 parent 51b0225 commit 5cece49

5 files changed

Lines changed: 206 additions & 219 deletions

File tree

dev/tests/playwright/tools/SpritesToolShell.spec.mjs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,8 @@ test("Sprite Creator shell loads with visible tool, canvas, details, and status
219219
await expect(page.locator("[data-sprites-work-area]")).toBeVisible();
220220
await expect(page.locator("[data-sprites-details-panel]")).toBeVisible();
221221
await expect(page.locator("[data-sprites-footer-status]")).toBeVisible();
222+
await expect(page.locator("main")).toContainText("Choose a drawing action for the current unsaved sprite draft.");
223+
await expect(page.locator("main")).toContainText("Saving to the sprite library remains deferred");
222224
await expect(page.locator("[data-sprites-tools-panel]")).toContainText("Sprite Tools");
223225
await expect(page.getByText("Drawing Tools", { exact: true })).toBeVisible();
224226
await expect(page.getByText("Canvas Setup", { exact: true })).toBeVisible();
@@ -274,7 +276,7 @@ test("Sprite Creator shell loads with visible tool, canvas, details, and status
274276
await expect(page.locator("[data-sprites-export-status]")).toContainText("PNG downloaded");
275277
await expect(page.locator("[data-sprites-shell-status]")).toContainText("Editor ready");
276278
await expect(page.locator("main")).toContainText("Palette/Colors remains the reusable color source");
277-
await expect(page.locator("main")).not.toContainText(/Not implemented yet|future rebuild work|Static wireframe only|Plan sprite creation/i);
279+
await expect(page.locator("main")).not.toContainText(/Not implemented yet|future rebuild work|Static wireframe only|Plan sprite creation|later editor slice/i);
278280
await expect(page.locator("style, [style], script:not([src])")).toHaveCount(0);
279281

280282
expect(failures.failedRequests).toEqual([]);
Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
# PR_26179_CHARLIE_028-sprites-editor-polish
2+
3+
Team: CHARLIE
4+
Workflow: stacked feature workflow
5+
Base branch: PR_26179_CHARLIE_027-sprites-preview-export
6+
Canonical ZIP path for this batch: dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip
7+
8+
## Summary
9+
10+
Polished Sprite Creator editor copy and status text. Removed stale wording such as "later editor slice" and improved manual validation clarity. Behavior is intentionally unchanged.
11+
12+
## Product Owner Testable Outcome
13+
14+
The Product Owner can open Sprite Creator and verify the editor communicates its current unsaved-draft behavior clearly while all existing editor interactions still work.
15+
16+
## Branch Validation
17+
18+
PASS
19+
20+
- Current branch: PR_26179_CHARLIE_028-sprites-editor-polish
21+
- Based on: PR_26179_CHARLIE_027-sprites-preview-export
22+
- No start_of_day files changed
23+
- No DB/API/schema files changed
24+
- No stale PR #219-#228 code copied
25+
26+
## Requirement Checklist
27+
28+
| Requirement | Status | Notes |
29+
| --- | --- | --- |
30+
| Fix outdated copy | PASS | Removed "later editor slice" wording. |
31+
| Improve status/manual validation clarity | PASS | Copy now explains unsaved editor workspace and deferred API-backed library save. |
32+
| Keep behavior unchanged | PASS | Only HTML copy and Playwright assertions changed. |
33+
| No DB/API/schema changes | PASS | None changed. |
34+
| No browser-owned authoritative product data | PASS | No persistence added. |
35+
36+
## Validation Lane Report
37+
38+
Commands:
39+
40+
```text
41+
node --check assets/toolbox/sprites/js/index.js
42+
node --check dev/tests/playwright/tools/SpritesToolShell.spec.mjs
43+
git diff --check -- toolbox/sprites/index.html dev/tests/playwright/tools/SpritesToolShell.spec.mjs
44+
rg --pcre2 -n -i "later editor slice|Not implemented yet|future rebuild work|Static wireframe only|Plan sprite creation|localStorage|sessionStorage|indexedDB|imageDataUrl|toDataURL|<style|style=|<script(?![^>]+src=)|on(click|change|submit|input|load|error)=|local-mem|fake-login|MEM DB" toolbox/sprites/index.html assets/toolbox/sprites/js/index.js
45+
npx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list --output=<temp>
46+
```
47+
48+
Results:
49+
50+
- Node syntax checks: PASS
51+
- `git diff --check`: PASS
52+
- Guard scan: PASS, no matches in page/runtime files
53+
- Targeted Playwright: PASS, 1 test passed
54+
55+
## Manual Validation Notes
56+
57+
1. Open `/toolbox/sprites/index.html`.
58+
2. Confirm the tools panel says "Choose a drawing action for the current unsaved sprite draft."
59+
3. Confirm the work area explains the sprite library save remains deferred to a future API-backed PR.
60+
4. Confirm Pencil/Eraser/Fill, palette, preview, and PNG export still work.
61+
62+
## Previous PR Dependency
63+
64+
PR_26179_CHARLIE_027-sprites-preview-export
65+
66+
## Next PR Dependency
67+
68+
PR_26179_CHARLIE_029-sprites-clear-reset-controls
69+
70+
## ZIP Path
71+
72+
`dev/workspace/zip/PR_26179_CHARLIE_028-sprites-editor-polish_delta.zip`
Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
toolbox/sprites/index.html
2-
assets/toolbox/sprites/js/index.js
3-
assets/theme-v2/css/gamefoundrystudio.css
1+
toolbox/sprites/index.html
42
dev/tests/playwright/tools/SpritesToolShell.spec.mjs
5-
docs_build/dev/reports/PR_26179_CHARLIE_027-sprites-preview-export.md
3+
docs_build/dev/reports/PR_26179_CHARLIE_028-sprites-editor-polish.md
64
docs_build/dev/reports/codex_changed_files.txt
75
docs_build/dev/reports/codex_review.diff

0 commit comments

Comments
 (0)