Skip to content

Commit 48d52b1

Browse files
authored
Merge pull request #158 from ToolboxAid/pr/26175-CHARLIE-010-system-health-history-and-closeout
PR_26175_CHARLIE_012-024-system-health-completion
2 parents 939c2ab + d522542 commit 48d52b1

78 files changed

Lines changed: 6330 additions & 944 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

admin/system-health.html

Lines changed: 181 additions & 0 deletions
Large diffs are not rendered by default.

assets/theme-v2/js/admin-system-health.js

Lines changed: 513 additions & 11 deletions
Large diffs are not rendered by default.
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# PR_26175_CHARLIE_012-017 System Health Phase 2 Closeout
2+
3+
## Scope
4+
5+
Team: Charlie
6+
7+
Workstream branch: `pr/26175-CHARLIE-010-system-health-history-and-closeout`
8+
9+
## Completed Phase 2 Slices
10+
11+
- PASS: PR_26175_CHARLIE_012-runtime-health
12+
- PASS: PR_26175_CHARLIE_013-service-health-dashboard
13+
- PASS: PR_26175_CHARLIE_014-configuration-summary
14+
- PASS: PR_26175_CHARLIE_015-manual-health-actions
15+
- PASS: PR_26175_CHARLIE_016-scheduled-health-monitoring
16+
- PASS: PR_26175_CHARLIE_017-health-notifications-foundation
17+
18+
## Architecture Closeout
19+
20+
- PASS: System Health remains one page per deployed environment.
21+
- PASS: Each deployment actively checks only itself.
22+
- PASS: Environment Map remains reference-only.
23+
- PASS: No cross-environment checks were added.
24+
- PASS: Web UI calls API/service contracts.
25+
- PASS: Browser does not own infrastructure health state.
26+
- PASS: Not Configured placeholders do not fake success.
27+
28+
## Validation Closeout
29+
30+
- PASS: Targeted System Health API/unit tests passed for each slice.
31+
- PASS: Targeted System Health Playwright tests passed for each slice.
32+
- PASS: Syntax checks passed for touched JavaScript modules.
33+
- PASS: `git diff --check` passed for each slice with CRLF warnings only.
34+
- NOT RUN: Full samples smoke; not required for System Health Phase 2.
35+
36+
## ZIP Artifacts
37+
38+
- `tmp/PR_26175_CHARLIE_012-runtime-health_delta.zip`
39+
- `tmp/PR_26175_CHARLIE_013-service-health-dashboard_delta.zip`
40+
- `tmp/PR_26175_CHARLIE_014-configuration-summary_delta.zip`
41+
- `tmp/PR_26175_CHARLIE_015-manual-health-actions_delta.zip`
42+
- `tmp/PR_26175_CHARLIE_016-scheduled-health-monitoring_delta.zip`
43+
- `tmp/PR_26175_CHARLIE_017-health-notifications-foundation_delta.zip`
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# PR_26175_CHARLIE_012 Branch Validation
2+
3+
## Start Gate
4+
5+
- PASS: Worktree was clean before Phase 2 implementation started.
6+
- PASS: Current branch was `pr/26175-CHARLIE-010-system-health-history-and-closeout`.
7+
- PASS: Branch history contained Charlie PRs 007 through 011.
8+
9+
## Branch Rules
10+
11+
- PASS: Continued on the existing Charlie workstream branch.
12+
- PASS: No merge was performed.
13+
- PASS: No rebase was performed.
14+
- PASS: No new root branch was created.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# PR_26175_CHARLIE_012 Manual Validation Notes
2+
3+
- Verified the Runtime Health table is present on `admin/system-health.html`.
4+
- Verified Runtime Health values are rendered from `/api/admin/system-health/status`.
5+
- Verified the page still blocks Creator sessions before System Health API calls.
6+
- Verified Runtime Environment remains a masked variable table and was not repurposed as Runtime Health.
7+
- Verified no cross-environment health checks were introduced.
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# PR_26175_CHARLIE_012 Requirement Checklist
2+
3+
- PASS: Added Runtime Health section.
4+
- PASS: Shows current environment.
5+
- PASS: Shows app/runtime version when available.
6+
- PASS: Shows API version when available.
7+
- PASS: Shows Node version from the server.
8+
- PASS: Shows server start time from the server.
9+
- PASS: Shows uptime from the server.
10+
- PASS: Shows last checked from the server.
11+
- PASS: Uses API/service contract data.
12+
- PASS: Browser does not own runtime health state.
13+
- PASS: Does not actively check other environments.
14+
- PASS: Tests were updated.
15+
- PASS: Required reports were generated.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR_26175_CHARLIE_012 Validation Report
2+
3+
## Commands
4+
5+
- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
6+
- PASS: `node --check assets/theme-v2/js/admin-system-health.js`
7+
- PASS: `git diff --check`
8+
- Result: no whitespace errors; CRLF conversion warnings only.
9+
- PASS: `node --test tests/dev-runtime/AdminHealthOperations.test.mjs`
10+
- Result: 4 passed.
11+
- PASS: `npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1 --reporter=line`
12+
- Result: 3 passed.
13+
14+
## Validation Lane
15+
16+
- Targeted System Health API/unit lane: PASS.
17+
- Targeted System Health Playwright lane: PASS.
18+
- Full samples smoke: not run; not required for this System Health-only slice.
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# PR_26175_CHARLIE_012 Runtime Health
2+
3+
## Scope
4+
5+
Team: Charlie
6+
7+
Purpose: Add current-deployment Runtime Health to Admin System Health Phase 2.
8+
9+
## Changes
10+
11+
- Added server-owned `runtimeHealth` to the Admin System Health status API.
12+
- Added Runtime Health UI table for environment, app/runtime version, API version, Node version, server start time, uptime, and last checked.
13+
- Kept Runtime Environment masking as a separate existing section.
14+
- Updated API and Playwright System Health tests for the Runtime Health contract.
15+
16+
## Architecture Notes
17+
18+
- PASS: Current deployment only.
19+
- PASS: Environment Map remains reference-only.
20+
- PASS: Browser renders API-owned runtime health state.
21+
- PASS: No cross-environment runtime checks were added.
22+
- PASS: No secrets are exposed.
23+
24+
## Artifact
25+
26+
- `tmp/PR_26175_CHARLIE_012-runtime-health_delta.zip`
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# PR_26175_CHARLIE_013 Branch Validation
2+
3+
## Branch Rules
4+
5+
- PASS: Continued on `pr/26175-CHARLIE-010-system-health-history-and-closeout`.
6+
- PASS: Stacked on PR_26175_CHARLIE_012.
7+
- PASS: No merge was performed.
8+
- PASS: No rebase was performed.
9+
- PASS: No new root branch was created.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# PR_26175_CHARLIE_013 Manual Validation Notes
2+
3+
- Verified Service Health cards render on `admin/system-health.html`.
4+
- Verified all seven requested service labels are present.
5+
- Verified visible card statuses are limited to Healthy, Warning, Failed, and Not Configured.
6+
- Verified Email and Background Jobs remain Not Configured placeholders.
7+
- Verified no peer environment health checks were introduced.

0 commit comments

Comments
 (0)