Skip to content

No CI: lint, type check and build never run on pull requests #48

Description

@royalpinto007

Desired outcome

A GitHub Actions workflow runs lint, type check, and build on every pull request.

Why it matters

There is no .github/workflows/ directory in this repo, so nothing is verified automatically. A PR that fails next lint, breaks tsc, or does not build can be merged and only discovered at deploy time. Formatting is also unenforced even though prettier and prettier-plugin-tailwindcss are dependencies and .prettierrc.json is committed, so diffs regularly carry unrelated reformatting noise.

The sibling repo AgentPostmortem/agent-postmortem has a workable .github/workflows/ci.yml (lint and type check, format check, build with placeholder env vars) that can be adapted.

Steps

  1. Add .github/workflows/ci.yml triggered on push to main and on pull_request.
  2. Jobs: npm ci, then npx tsc --noEmit, npm run lint, npx prettier --check ., and npm run build.
  3. Use actions/setup-node with node-version: 20 (matching the engines field) and cache: npm.
  4. The build needs the public env vars from .env.example; supply harmless placeholder values in the workflow env block so no secret is required.

Claiming this

Comment below to claim it. A reply usually comes within a day.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions