From 9238d57bced1262563d1dcb684eaa57cf856b949 Mon Sep 17 00:00:00 2001 From: Chad Bentz <1760475+felickz@users.noreply.github.com> Date: Mon, 3 Aug 2026 16:31:05 -0400 Subject: [PATCH] Fix publish summary showing no result for go/python ext-library-sources MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit go and python only ship an ext (model/extension) pack, not ext-library-sources - that pack only exists for csharp/java (see the library_sources_extensions job's matrix in publish.yml). The summary script incorrectly reused the ext-pack language list to also gate the ext-library-sources column, so go/python were expected to have a result there and rendered '❓ no result' instead of 'n/a' (seen in the v0.7.2 release notes). Introduces a separate EXT_LIBRARY_SOURCES_LANGUAGES list (csharp java) matching that job's matrix, and checks it independently per column. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0baa8375-5974-4c3a-904d-707bc1c493dd --- .github/scripts/build-publish-summary.sh | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/.github/scripts/build-publish-summary.sh b/.github/scripts/build-publish-summary.sh index cccc71aa..ed6d909c 100755 --- a/.github/scripts/build-publish-summary.sh +++ b/.github/scripts/build-publish-summary.sh @@ -36,7 +36,12 @@ fi LANGUAGES=(cpp csharp go java javascript python ruby) TYPES=(src lib ext ext-library-sources) +# Languages with an `ext` (model/extension) pack - matches the `extensions` job's matrix. EXT_LANGUAGES=(csharp go java python) +# Languages with an `ext-library-sources` pack - matches the `library_sources_extensions` +# job's matrix. This is a strict subset of EXT_LANGUAGES: go/python ship `ext` packs but +# have no `ext-library-sources` pack, so they must not be expected to have a result for it. +EXT_LIBRARY_SOURCES_LANGUAGES=(csharp java) lang_label() { case "$1" in @@ -59,6 +64,14 @@ is_ext_language() { return 1 } +is_ext_library_sources_language() { + local lang="$1" + for l in "${EXT_LIBRARY_SOURCES_LANGUAGES[@]}"; do + [ "$l" == "$lang" ] && return 0 + done + return 1 +} + # Escapes a string for safe embedding in an RE2 regex pattern (used to match # a specific version tag literally in download_badge's search regex below). regex_escape() { @@ -146,7 +159,11 @@ echo "| --- | --- | --- | --- | --- |" for lang in "${LANGUAGES[@]}"; do row="| $(lang_label "$lang") |" for type in "${TYPES[@]}"; do - if { [ "$type" == "ext" ] || [ "$type" == "ext-library-sources" ]; } && ! is_ext_language "$lang"; then + if [ "$type" == "ext" ] && ! is_ext_language "$lang"; then + row="$row n/a |" + continue + fi + if [ "$type" == "ext-library-sources" ] && ! is_ext_library_sources_language "$lang"; then row="$row n/a |" continue fi