Summary
v10.1.0 adds the UnsafeEntityLogging option to TableControllerOptions (see #446). When false (the new default) only the entity ID is logged at Information level and the full serialized entity is never written to the logs; when true the full serialized entity is logged at Debug.
This sample is not the docs-tutorial walkthrough (it is the TodoMVC sample referenced from the server/client tutorials), so it should keep the secure default (UnsafeEntityLogging = false). This issue tracks reviewing the sample against v10.1.0 and explicitly documenting the secure default.
Change required
Review the server project samples/todoapp-mvc/TodoApp.Service:
Controllers/TodoItemsController.cs
This controller does not currently configure TableControllerOptions, so UnsafeEntityLogging already defaults to the secure value of false. Optionally add a brief comment (or explicit Options block) documenting that entity logging is intentionally left disabled to avoid logging potentially sensitive entity contents.
Acceptance criteria
Related
Summary
v10.1.0 adds the
UnsafeEntityLoggingoption toTableControllerOptions(see #446). Whenfalse(the new default) only the entity ID is logged atInformationlevel and the full serialized entity is never written to the logs; whentruethe full serialized entity is logged atDebug.This sample is not the docs-tutorial walkthrough (it is the TodoMVC sample referenced from the server/client tutorials), so it should keep the secure default (
UnsafeEntityLogging = false). This issue tracks reviewing the sample against v10.1.0 and explicitly documenting the secure default.Change required
Review the server project
samples/todoapp-mvc/TodoApp.Service:Controllers/TodoItemsController.csThis controller does not currently configure
TableControllerOptions, soUnsafeEntityLoggingalready defaults to the secure value offalse. Optionally add a brief comment (or explicitOptionsblock) documenting that entity logging is intentionally left disabled to avoid logging potentially sensitive entity contents.Acceptance criteria
UnsafeEntityLoggingremainsfalse(default) in this sample.Options).Related
UnauthorizedStatusCodeis set, and the conflict-hiding change is internal).