Skip to content

Examples: Review todoapp-mvc server for UnsafeEntityLogging secure default (#446) #480

Description

@adrianhall

Summary

v10.1.0 adds the UnsafeEntityLogging option to TableControllerOptions (see #446). When false (the new default) only the entity ID is logged at Information level and the full serialized entity is never written to the logs; when true the full serialized entity is logged at Debug.

This sample is not the docs-tutorial walkthrough (it is the TodoMVC sample referenced from the server/client tutorials), so it should keep the secure default (UnsafeEntityLogging = false). This issue tracks reviewing the sample against v10.1.0 and explicitly documenting the secure default.

Change required

Review the server project samples/todoapp-mvc/TodoApp.Service:

  • Controllers/TodoItemsController.cs

This controller does not currently configure TableControllerOptions, so UnsafeEntityLogging already defaults to the secure value of false. Optionally add a brief comment (or explicit Options block) documenting that entity logging is intentionally left disabled to avoid logging potentially sensitive entity contents.

Acceptance criteria

  • UnsafeEntityLogging remains false (default) in this sample.
  • The deliberate secure default is documented (comment or explicit Options).
  • The sample builds and runs against v10.1.0.

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    ExamplesServerImprovements or additions to the server code

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions