From ec0be2412518061eb5e4b87e98181bef67d8e339 Mon Sep 17 00:00:00 2001 From: shafiekwalker7861 Date: Tue, 18 Aug 2026 12:49:12 +0200 Subject: [PATCH 1/2] Fix Book Library bugs --- debugging/book-library/script.js | 133 ++++++++++++++++++------------- 1 file changed, 78 insertions(+), 55 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..b0ccc5e1 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,22 +1,28 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + if (myLibrary.length === 0) { + const book1 = new Book( + "Robinson Crusoe", + "Daniel Defoe", + "252", + true + ); + + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", "127", true ); + myLibrary.push(book1); myLibrary.push(book2); - render(); } } @@ -25,22 +31,34 @@ const author = document.getElementById("author"); const pages = document.getElementById("pages"); const check = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function function submit() { if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" + title.value.trim() === "" || + author.value.trim() === "" || + pages.value.trim() === "" ) { alert("Please fill all fields!"); return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); } + + const book = new Book( + title.value.trim(), + author.value.trim(), + pages.value, + check.checked + ); + + myLibrary.push(book); + + render(); + + // Clear the form after adding a book + title.value = ""; + author.value = ""; + pages.value = ""; + check.checked = false; + + return true; } function Book(title, author, pages, check) { @@ -51,53 +69,58 @@ function Book(title, author, pages, check) { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + const table = document.getElementById("display"); + const rowsNumber = table.rows.length; + + // Remove old book rows but keep the heading row + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { + + for (let i = 0; i < myLibrary.length; i++) { + const row = table.insertRow(-1); + + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + + titleCell.textContent = myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; + + // Read / unread button + const changeButton = document.createElement("button"); + + changeButton.className = "btn btn-success"; + + changeButton.textContent = myLibrary[i].check + ? "Yes" + : "No"; + + changeButton.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + wasReadCell.appendChild(changeButton); + + // Delete button + const deleteButton = document.createElement("button"); + + deleteButton.className = "btn btn-warning"; + deleteButton.textContent = "Delete"; + + deleteButton.addEventListener("click", function () { + alert( + `You've deleted title: ${myLibrary[i].title}` + ); + myLibrary.splice(i, 1); render(); }); + + deleteCell.appendChild(deleteButton); } -} +} \ No newline at end of file From 5a3548a6269c5c44a3353396dc6e5b0cab47cc4b Mon Sep 17 00:00:00 2001 From: shafiekwalker7861 Date: Tue, 18 Aug 2026 14:24:35 +0200 Subject: [PATCH 2/2] Improve Book Library based on review feedback --- debugging/book-library/index.html | 190 ++++++++++++++++++------------ debugging/book-library/script.js | 178 +++++++++++++++------------- 2 files changed, 210 insertions(+), 158 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..fc7fde07 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,96 +1,134 @@ - + - + + + Book Library + + - + + -
+

Library

Add books to your virtual library

-
- - - -
-
- - - - - - - - + + +
+ + +
+
+
+ + + +
+ +
+ + + +
+ +
+ + + +
+ +
+ + + +
+ + +
-
- - - - - - - - - - - - - - - - - - - - -
TitleAuthorNumber of PagesRead
- - + +

+ + + + + + + + + + + + + +
TitleAuthorNumber of PagesReadActions
+ + + - + \ No newline at end of file diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index b0ccc5e1..ce6a3883 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,126 +1,140 @@ -let myLibrary = []; +const myLibrary = []; -window.addEventListener("load", function () { - populateStorage(); - render(); -}); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckbox = document.getElementById("check"); +const bookForm = document.getElementById("book-form"); +const bookList = document.getElementById("book-list"); +const messageEl = document.getElementById("message"); + +function Book(title, author, pages, check) { + this.title = title; + this.author = author; + this.pages = pages; + this.check = check; +} function populateStorage() { - if (myLibrary.length === 0) { - const book1 = new Book( - "Robinson Crusoe", - "Daniel Defoe", - "252", - true - ); + if (myLibrary.length > 0) { + return; + } - const book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); + const book1 = new Book( + "Robinson Crusoe", + "Daniel Defoe", + 252, + true + ); - myLibrary.push(book1); - myLibrary.push(book2); - } + const book2 = new Book( + "The Old Man and the Sea", + "Ernest Hemingway", + 127, + true + ); + + myLibrary.push(book1, book2); } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); - -function submit() { - if ( - title.value.trim() === "" || - author.value.trim() === "" || - pages.value.trim() === "" - ) { - alert("Please fill all fields!"); - return false; +function addBook(event) { + event.preventDefault(); + + const title = titleInput.value.trim(); + const author = authorInput.value.trim(); + const pages = Number(pagesInput.value); + + if (title === "" || author === "") { + showMessage("Please enter a title and author."); + return; + } + + if (!Number.isInteger(pages) || pages <= 0) { + showMessage("Please enter a valid number of pages."); + return; } const book = new Book( - title.value.trim(), - author.value.trim(), - pages.value, - check.checked + title, + author, + pages, + readCheckbox.checked ); myLibrary.push(book); - render(); - - // Clear the form after adding a book - title.value = ""; - author.value = ""; - pages.value = ""; - check.checked = false; + bookForm.reset(); - return true; + render(); + showMessage(`"${book.title}" was added successfully.`); } -function Book(title, author, pages, check) { - this.title = title; - this.author = author; - this.pages = pages; - this.check = check; +function showMessage(message) { + messageEl.textContent = message; } function render() { - const table = document.getElementById("display"); - const rowsNumber = table.rows.length; - - // Remove old book rows but keep the heading row - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } + // Remove all existing book rows at once + bookList.replaceChildren(); for (let i = 0; i < myLibrary.length; i++) { - const row = table.insertRow(-1); + const book = myLibrary[i]; - const titleCell = row.insertCell(0); - const authorCell = row.insertCell(1); - const pagesCell = row.insertCell(2); - const wasReadCell = row.insertCell(3); - const deleteCell = row.insertCell(4); + const row = document.createElement("tr"); - titleCell.textContent = myLibrary[i].title; - authorCell.textContent = myLibrary[i].author; - pagesCell.textContent = myLibrary[i].pages; + const titleCell = document.createElement("td"); + const authorCell = document.createElement("td"); + const pagesCell = document.createElement("td"); + const readCell = document.createElement("td"); + const deleteCell = document.createElement("td"); - // Read / unread button - const changeButton = document.createElement("button"); + titleCell.textContent = book.title; + authorCell.textContent = book.author; + pagesCell.textContent = book.pages; + const changeButton = document.createElement("button"); changeButton.className = "btn btn-success"; - - changeButton.textContent = myLibrary[i].check - ? "Yes" - : "No"; + changeButton.textContent = book.check ? "Yes" : "No"; changeButton.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + book.check = !book.check; render(); }); - wasReadCell.appendChild(changeButton); - - // Delete button const deleteButton = document.createElement("button"); - deleteButton.className = "btn btn-warning"; deleteButton.textContent = "Delete"; deleteButton.addEventListener("click", function () { - alert( - `You've deleted title: ${myLibrary[i].title}` - ); + const deletedTitle = book.title; myLibrary.splice(i, 1); + render(); + + showMessage(`You've deleted title: ${deletedTitle}`); }); + readCell.appendChild(changeButton); deleteCell.appendChild(deleteButton); + + row.append( + titleCell, + authorCell, + pagesCell, + readCell, + deleteCell + ); + + bookList.appendChild(row); } -} \ No newline at end of file +} + +function initialiseLibrary() { + populateStorage(); + render(); +} + +bookForm.addEventListener("submit", addBook); + +initialiseLibrary(); \ No newline at end of file